fix: update prop spreading for ActionBar #219
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cjskillingstad
approved these changes
Jan 16, 2019
greg-a-smith
suggested changes
Jan 16, 2019
src/ActionBar/ActionBar.js
Outdated
| <p className='fd-action-bar__description'>{description} </p> | ||
| <h1 | ||
| className='fd-action-bar__title' | ||
| {...titleProps}>{title}</h1> |
There was a problem hiding this comment.
After looking at this some more, I think we want the spread to occur first and then the hard-coded props. Otherwise, consumers could literally override required prop values. In these two cases, it will also leverage some capabilities of the classnames story to make sure they can include additional classes.
There was a problem hiding this comment.
Good call - I'll need to fix this on the other pr's too
greg-a-smith
suggested changes
Jan 17, 2019
| { | ||
| name: 'buttonProps', | ||
| description: 'object - additional props to be spread to the ActionBarBack\'s button.' | ||
| }, |
There was a problem hiding this comment.
The buttonProps are actually for the ActionBarBack component. That said, I would like to circle back in another story and adjust the documentation pages to properly define all the components AND sub components AND each of their respective props better.
See #238
greg-a-smith
pushed a commit
that referenced
this pull request
Mar 5, 2019
* update prop spreading for ActionBar * move spreads * update documentation with new props
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds additional props to enable spreading into button, h1 and p elements.