Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: prop spreading to breadcrumb #223

Merged
merged 2 commits into from
Jan 17, 2019
Merged

fix: prop spreading to breadcrumb #223

merged 2 commits into from
Jan 17, 2019

Conversation

jbadan
Copy link
Contributor

@jbadan jbadan commented Jan 16, 2019

allow prop spreading to Breadcrumb

greg-a-smith
greg-a-smith suggested changes Jan 17, 2019
View reviewed changes
Copy link
Contributor

@greg-a-smith greg-a-smith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merging blocked until fundamental-bot admin rights are restored.

greg-a-smith
greg-a-smith reviewed Jan 17, 2019
View reviewed changes
Copy link
Contributor

@greg-a-smith greg-a-smith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the changes look good. 🚢 I can approve once merging is allowed.

greg-a-smith
greg-a-smith approved these changes Jan 17, 2019
View reviewed changes
Copy link
Contributor

@greg-a-smith greg-a-smith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's roll 🎢

@jbadan jbadan merged commit fb038c9 into master Jan 17, 2019
@jbadan jbadan deleted the fix/breadcrumb-spread branch January 17, 2019 18:19
@jbadan jbadan mentioned this pull request Jan 22, 2019
Closed
greg-a-smith pushed a commit that referenced this pull request Mar 5, 2019
@jbadan
fix: prop spreading to breadcrumb (#223)
79a1c29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@greg-a-smith greg-a-smith greg-a-smith approved these changes

@cjskillingstad cjskillingstad cjskillingstad approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jbadan @greg-a-smith @cjskillingstad