Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Prop spreading to Toggle #227

Merged
merged 1 commit into from
Jan 17, 2019
Merged

fix: Prop spreading to Toggle #227

merged 1 commit into from
Jan 17, 2019

Conversation

cjskillingstad
Copy link
Contributor

  • Spread props to Toggle's elements
  • Update unit tests
  • Update docs

@cjskillingstad cjskillingstad requested a review from a team January 16, 2019 22:40
greg-a-smith
greg-a-smith suggested changes Jan 17, 2019
View reviewed changes
Copy link
Contributor

@greg-a-smith greg-a-smith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merging blocked until fundamental-bot admin rights are restored.

greg-a-smith
greg-a-smith reviewed Jan 17, 2019
View reviewed changes
Copy link
Contributor

@greg-a-smith greg-a-smith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the changes look good. 🚢 I can approve once merging is allowed.

greg-a-smith
greg-a-smith approved these changes Jan 17, 2019
View reviewed changes
Copy link
Contributor

@greg-a-smith greg-a-smith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's roll 🎢

@cjskillingstad cjskillingstad merged commit 9e5959e into master Jan 17, 2019
@cjskillingstad cjskillingstad deleted the fix/toggle-spread branch January 17, 2019 21:34
@jbadan jbadan mentioned this pull request Jan 22, 2019
Closed
greg-a-smith pushed a commit that referenced this pull request Mar 5, 2019
@cjskillingstad
Spread props to elements (#227)
8c27d27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mobot11 mobot11 mobot11 approved these changes

@greg-a-smith greg-a-smith greg-a-smith approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@cjskillingstad @mobot11 @greg-a-smith