Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Prop spreading for Forms #246

Merged
merged 1 commit into from
Jan 17, 2019
Merged

fix: Prop spreading for Forms #246

merged 1 commit into from
Jan 17, 2019

Conversation

greg-a-smith
Copy link
Contributor

No description provided.

@greg-a-smith greg-a-smith requested a review from a team January 17, 2019 19:35
@greg-a-smith
Copy link
Contributor Author

NOTE: I left the FormRadio tests x'd out because I actually think the component itself should be refactored to better allow for prop spreading. See #247 .

chrismanciero
chrismanciero approved these changes Jan 17, 2019
View reviewed changes
Copy link
Contributor

@chrismanciero chrismanciero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

@greg-a-smith greg-a-smith merged commit e4a7a75 into master Jan 17, 2019
@greg-a-smith greg-a-smith deleted the fix/form-spread branch January 17, 2019 21:33
@jbadan jbadan mentioned this pull request Jan 22, 2019
Closed
greg-a-smith added a commit that referenced this pull request Mar 5, 2019
@greg-a-smith
fix: Prop spreading for Forms (#246)
b257fd9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chrismanciero chrismanciero chrismanciero approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@greg-a-smith @chrismanciero