fix: Prop spreading for SideNavigation #248
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mobot11
approved these changes
Jan 17, 2019
greg-a-smith
suggested changes
Jan 17, 2019
src/SideNavigation/SideNavigation.js
Outdated
| return ( | ||
| <div | ||
| className={`fd-side-nav__group${className ? ' ' + className : ''}`} | ||
| {...rest}> | ||
| <h1 className='fd-side-nav__title'>{title}</h1> | ||
| <h1 {...headerProps} className='fd-side-nav__title'>{title}</h1> |
There was a problem hiding this comment.
@jbadan had a similar change to a different component and used titleProps as the name, which seems to fit a little better since the content of this element is the title prop.
There was a problem hiding this comment.
On an unrelated note, this element should assume the use of <h1>. There should only be one <h1> per page and assuming it will exist in the side navigation seems wrong. I created #249 to address that in a future story.
greg-a-smith
pushed a commit
that referenced
this pull request
Mar 5, 2019
* Add prop spreading * Add spread
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The documentation for this component didn't include the props for the component that I added prop spreading to so I didn't update docs.