Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: revert react-dev-utils breaking changes dep bump #636

Merged
merged 1 commit into from
Jun 28, 2019

Conversation

jbadan
Copy link
Contributor

@jbadan jbadan commented Jun 28, 2019

Description

Reverting this change: #625

This commit https://github.com/facebook/create-react-app/pull/6586/files breaks our start script by changing the way the arguments are passed to createCompiler

Also added eslint config to stop warning that cropped up from another bump.

fixes #issueid

@jbadan jbadan requested a review from hertweckhr1 June 28, 2019 16:07
@netlify
Copy link

netlify bot commented Jun 28, 2019

Deploy preview for fundamental-react ready!

Built with commit c07f86f

https://deploy-preview-636--fundamental-react.netlify.com

Copy link
Contributor

@hertweckhr1 hertweckhr1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 looks good

@jbadan jbadan merged commit 545a4a7 into master Jun 28, 2019
@jbadan jbadan deleted the fix/revert-react-dev branch June 28, 2019 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants