Skip to content

Commit

Permalink
fix: refactored link mixin using theme parameters (#379)
Browse files Browse the repository at this point in the history
* refactored mixin

* removed link states
  • Loading branch information
stefanoScalzo committed Oct 23, 2019
1 parent b72bb48 commit 0d4c30f
Show file tree
Hide file tree
Showing 3 changed files with 11 additions and 38 deletions.
4 changes: 0 additions & 4 deletions docs/pages/components/link.md
Original file line number Diff line number Diff line change
Expand Up @@ -14,10 +14,6 @@ Used when extra emphasis is needed especially when a link needs to standout from

<br>

## Link States
* Selected state can be rendered using class `is-selected` and/or `aria-selected="true"` attribute
* Disabled state can be rendered using class `is-disabled` and/or `aria-disabled="true"` attribute

{% capture default %}
<a href="#" class="fd-link">Standard Link</a>
<br><br>
Expand Down
45 changes: 11 additions & 34 deletions src/mixins/_mixins.scss
Original file line number Diff line number Diff line change
Expand Up @@ -267,59 +267,36 @@
}
}

@mixin fd-link($color: $fd-color--action) {
@include fd-var-color("color", $fd-color--action, --fd-color-action-1);

@mixin fd-link() {
color: var(--sapLinkColor);
text-decoration: none;
display: inline-block;
transition: all $fd-animation--speed ease-in;
border-bottom-style: solid;
border-bottom-width: 1px;

@include fd-var-color("border-bottom-color", $fd-color--action, --fd-color-action-1);
border-bottom-color: var (--sapLinkColor);

@include fd-hover() {
@include fd-var-color("color", map-get($fd-colors-action-states, "hover"), --fd-color-action-hover);
@include fd-var-color("border-bottom-color", map-get($fd-colors-action-states, "hover"), --fd-color-action-hover);
color: var(--sapLink_Hover_Color);
border-bottom-color: var(--sapLink_Hover_Color);
}

&:visited {
@include fd-var-color("color", map-get($fd-colors-action-states, "visited"), --fd-color-action-visited);
@include fd-var-color(
"border-bottom-color",
map-get($fd-colors-action-states, "visited"),
--fd-color-action-visited
);
}

@include fd-active-pressed-selected() {
@include fd-var-color("color", map-get($fd-colors-action-states, "selected"), --fd-color-action-selected);
@include fd-var-color(
"border-bottom-color",
map-get($fd-colors-action-states, "selected"),
--fd-color-action-selected
);

outline: none;
color: var(--sapLink_Visited_Color);
border-bottom-color: var(--sapLink_Visited_Color);
}

@include fd-disabled() {
@include fd-var-color("color", map-get($fd-colors-action-states, "disabled"), --fd-color-action-disabled);
@include fd-var-color(
"border-bottom-color",
map-get($fd-colors-action-states, "disabled"),
--fd-color-action-disabled
);
@include fd-var-color("outline-color", fd-color-state("disabled", "action"), --fd-color-action-disabled);

opacity: 0.4;
color: var(--sapLinkColor);
border-bottom-color: var(--sapLinkColor);
cursor: not-allowed;
}

&:focus {
outline-style: dotted;
outline-width: 1px;

@include fd-var-color("outline-color", fd-color-state("hover", "action"), --fd-color-action-focus);
outline-color: var(--sapLinkColor);
}
}

Expand Down
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.

0 comments on commit 0d4c30f

Please sign in to comment.