fix: update modal docs to remove .modal-demo-bg #593
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbadan
commented
Jan 17, 2020
| background-color:rgba(0, 0, 0, 0.5); | ||
| padding: 40px; | ||
| } | ||
|
|
There was a problem hiding this comment.
@InnaAtanasova do you think we can just remove this file entirely and cleanup head_print.html? Or maybe even delete head_print? It's referencing a ton of css that doesn't exist anymore and I'm not sure we still need it.
|
Deploy preview for fundamental-styles ready! Built with commit c78b349 |
InnaAtanasova
approved these changes
Jan 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This class was only referenced in
customstyles.css, which is not used on the docs site (it is only called inhead_print.html.This was causing confusion as to whether that div was actually necessary.
Screenshots
Before:
After: