Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: update modal docs to remove .modal-demo-bg #593

Merged
merged 2 commits into from
Jan 17, 2020
Merged

fix: update modal docs to remove .modal-demo-bg #593

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b2f92bf
update modal docs
jbadan Jan 17, 2020
c78b349
remove custom styles
jbadan Jan 17, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
5 changes: 0 additions & 5 deletions docs/css/customstyles.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1102,11 +1102,6 @@ h4.panel-title {
text-align: center;
}

.modal-demo-bg{
background-color:rgba(0, 0, 0, 0.5);
padding: 40px;
}

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@InnaAtanasova do you think we can just remove this file entirely and cleanup head_print.html? Or maybe even delete head_print? It's referencing a ton of css that doesn't exist anymore and I'm not sure we still need it.

pre code{
white-space:pre-wrap
overflow-x: scroll;
Expand Down
6 changes: 0 additions & 6 deletions docs/pages/components/modal.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,6 @@ It is used for short forms, confirmation messages or to display contextual infor
This is used to present information to the user but the Alert Component doesn’t fit all the information.

{% capture default-modal %}
<div class="modal-demo-bg">
<div class="fd-modal">
<div class="fd-modal__content" role="document">
<div class="fd-modal__header">
Expand All @@ -36,7 +35,6 @@ This is used to present information to the user but the Alert Component doesn’
</div>
</div>
</div>
</div>
{% endcapture %}

{% include display-component.html component=default-modal %}
Expand All @@ -47,7 +45,6 @@ This is used to present information to the user but the Alert Component doesn’
This is used to confirm with the user before continuing with a destructive or complex action. In this case, the modal has action buttons at the bottom.

{% capture default-confirmation %}
<div class="modal-demo-bg">
<div class="fd-modal">
<div class="fd-modal__content" role="document">
<div class="fd-modal__header">
Expand All @@ -63,7 +60,6 @@ This is used to confirm with the user before continuing with a destructive or co
</footer>
</div>
</div>
</div>
{% endcapture %}

{% include display-component.html component=default-confirmation %}
Expand All @@ -74,7 +70,6 @@ This is used to confirm with the user before continuing with a destructive or co
This is used for short forms in order to collect information from the user.

{% capture default-form %}
<div class="modal-demo-bg">
<div class="fd-modal">
<div class="fd-modal__content" role="document">
<div class="fd-modal__header">
Expand All @@ -93,7 +88,6 @@ This is used for short forms in order to collect information from the user.
</footer>
</div>
</div>
</div>
{% endcapture %}

{% include display-component.html component=default-form %}