Add openNodeInModal attribute to Profile section of the documentation #1704
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
UlianaMunich
requested review from
alexandra-simeonova,
hardl,
JohannesDoberer,
maxmarkus,
ndricimrr and
stanleychh
as code owners
JohannesDoberer
approved these changes
Nov 13, 2020
alexandra-simeonova
approved these changes
Nov 16, 2020
JohannesDoberer
changed the title
Co-authored-by: Aleksandra Simeonova <aleksandra.simeonova@sap.com>
JohannesDoberer
added a commit
to hardl/luigi
that referenced
this pull request
Nov 20, 2020
* master: Add openNodeInModal attribute to Profile section of the documentation (SAP#1704) Drawer component (SAP#1659) # Conflicts: # core/src/App.html # core/src/Modal.html # test/e2e-test-application/src/app/project/project.component.html # test/e2e-test-application/src/luigi-config/extended/projectDetailNav.js
JohannesDoberer
added a commit
that referenced
this pull request
Nov 23, 2020
* master: Fix css issue for Iframe (#1716) Luigi Tutorials blog post (#1699) Add openNodeInModal attribute to Profile section of the documentation (#1704) Drawer component (#1659) Safari bug with shellbar dropdowns blue outlie (#1689) Bump versions yargs-parser and node-forge (#1683) # Conflicts: # core/src/App.html # core/src/Modal.html # test/e2e-test-application/e2e/tests/1-angular/luigi-client-link-manager-features.spec.js # test/e2e-test-application/src/app/project/project.component.html # test/e2e-test-application/src/luigi-config/extended/projectDetailNav.js
Merged
stanleychh
pushed a commit
to stanleychh/luigi
that referenced
this pull request
Dec 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1700