Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove default outline for iframeContainer#1713 #1716

Conversation

legteodav
Copy link
Contributor

Just test it new style in local in example-angular-application (copy Joke of they day item)....

Related issue(s)
Fixes #1713

@stanleychh stanleychh self-assigned this Nov 20, 2020
@hardl hardl merged commit 74ba6ca into SAP:master Nov 20, 2020
JohannesDoberer added a commit that referenced this pull request Nov 23, 2020
* master:
  Fix css issue for Iframe (#1716)
  Luigi Tutorials blog post (#1699)
  Add openNodeInModal attribute to Profile section of the documentation (#1704)
  Drawer component (#1659)
  Safari bug with shellbar dropdowns blue outlie (#1689)
  Bump versions yargs-parser and node-forge (#1683)

# Conflicts:
#	core/src/App.html
#	core/src/Modal.html
#	test/e2e-test-application/e2e/tests/1-angular/luigi-client-link-manager-features.spec.js
#	test/e2e-test-application/src/app/project/project.component.html
#	test/e2e-test-application/src/luigi-config/extended/projectDetailNav.js
@ndricimrr ndricimrr added the bug Something isn't working label Nov 24, 2020
@ndricimrr ndricimrr mentioned this pull request Nov 25, 2020
@JohannesDoberer JohannesDoberer added this to the Sprint 14 milestone Nov 25, 2020
JohannesDoberer added a commit that referenced this pull request Nov 25, 2020
* master:
  add blog post (#1731)
  Release v1.6.0 (#1729)
  cm fix (#1727)
  Added state info to replacestate (#1725)
  Simple storage api for micro frontends#1696 (#1707)
  Fix broken angular link (#1717)
  Fix css issue for Iframe (#1716)
JohannesDoberer added a commit to JohannesDoberer/luigi that referenced this pull request Nov 25, 2020
* feature-user-settings:
  add blog post (SAP#1731)
  Release v1.6.0 (SAP#1729)
  cm fix (SAP#1727)
  Profile setting dialog (SAP#1710)
  Added state info to replacestate (SAP#1725)
  Simple storage api for micro frontends#1696 (SAP#1707)
  Fix broken angular link (SAP#1717)
  Fix css issue for Iframe (SAP#1716)

# Conflicts:
#	test/e2e-test-application/src/luigi-config/extended/settings.js
stanleychh pushed a commit to stanleychh/luigi that referenced this pull request Dec 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

remove default outline for iframeContainer
5 participants