Replace protractor with cypress #3763
Conversation
walmazacn
requested review from
hardl,
JohannesDoberer,
ndricimrr,
VincentUllal,
smahati and
amilewskaa
as code owners
walmazacn
force-pushed
the
3762-replace-protractor-with-cypress
branch
from
4842653
to
f75e87f
Compare
There was a problem hiding this comment.
After looking again in my opinon we don't need the cypress related changes to client-frameworks-support/client-support-angular because we have test scenarios for the functionality of this library in our e2e-test-application. What do you think?
In addition I have run the tests for e2e-test-application (npm run e2e:run:angular) and not sure if we use schematics which are defined in angular.json?
Do we need this changes for our test setup?
Removing protractor stuff looks good to me.
|
@JohannesDoberer I removed extra files related to 'client-support-angular' - truth is migration tool was not needed in this case Regarding 'e2e-test-application' - it seems migration tool was needed mainly for "luigisample-e2e" app, as Protractor was used as a builder there. Anyway, I'm not sure if "luigisample-e2e" is used for anything |
Description
Changes proposed in this pull request:
Related issue(s)
Resolves #3762