Fix hang when read stream error occurs #226
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes potential hangs when read stream errors occur for LOB parameters. In particular, these hangs could have happened when stream read errors occur between writeLOB chunks or before the parameter is bound. Bug: 316072
davidbrandow
approved these changes
Jan 25, 2024
jeffalbion
approved these changes
Jan 25, 2024
davidbrandow
approved these changes
Jan 26, 2024
jeffalbion
approved these changes
Jan 26, 2024
johannes-vogel
pushed a commit
to cap-js/cds-dbs
that referenced
this pull request
Mar 25, 2024
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [hdb](https://togithub.com/SAP/node-hdb) | [`0.19.7` -> `0.19.8`](https://renovatebot.com/diffs/npm/hdb/0.19.7/0.19.8) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>SAP/node-hdb (hdb)</summary> ### [`v0.19.8`](https://togithub.com/SAP/node-hdb/releases/tag/v0.19.8) [Compare Source](https://togithub.com/SAP/node-hdb/compare/v0.19.7...v0.19.8) ##### What's Changed - Ensure client.exec callback is called if client is closed by [@​IanMcCurdy](https://togithub.com/IanMcCurdy) in [SAP/node-hdb#224 - \[Test] Fix hanging ResultSetTransform test by [@​IanMcCurdy](https://togithub.com/IanMcCurdy) in [SAP/node-hdb#225 - Fix hang when read stream error occurs by [@​IanMcCurdy](https://togithub.com/IanMcCurdy) in [SAP/node-hdb#226 - \[TEST] Fix failing req.Authenticate test by [@​IanMcCurdy](https://togithub.com/IanMcCurdy) in [SAP/node-hdb#227 - Fix calling undefined cb in Connection.prototype.enqueue by [@​IanMcCurdy](https://togithub.com/IanMcCurdy) in [SAP/node-hdb#229 - Fix ESLint errors by [@​IanMcCurdy](https://togithub.com/IanMcCurdy) in [SAP/node-hdb#231 - Update to 0.19.8 by [@​IanMcCurdy](https://togithub.com/IanMcCurdy) in [SAP/node-hdb#230 **Full Changelog**: SAP/node-hdb@v0.19.7...v0.19.8 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about these updates again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/cap-js/cds-dbs). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4yNjkuMiIsInVwZGF0ZWRJblZlciI6IjM3LjI2OS4yIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
](https://renovatebot.com){kind=link}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes potential hangs when read stream errors occur for LOB parameters. In particular, these hangs could have happened when stream read errors occur between writeLOB chunks or before the parameter is bound.
Bug: 316072