Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: introduce a basic support for etags #828

Merged
merged 4 commits into from
Jul 2, 2024
Merged

feat: introduce a basic support for etags #828

merged 4 commits into from
Jul 2, 2024

Conversation

nlunets
Copy link
Member

@nlunets nlunets commented Jul 1, 2024

Introduced a new service configuration settings validateETag that should force a 412 error when an update doesn't contain the proper If-Match value

Copy link

changeset-bot bot commented Jul 1, 2024

🦋 Changeset detected

Latest commit: a7eb814

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@sap-ux/ui5-middleware-fe-mockserver Patch
@sap-ux/fe-mockserver-core Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Co-authored-by: Dirk Teufel <50441133+drktfl@users.noreply.github.com>
Copy link

sonarcloud bot commented Jul 2, 2024

@nlunets nlunets merged commit b215858 into main Jul 2, 2024
12 checks passed
@nlunets nlunets deleted the etags branch July 2, 2024 07:55
otsquest101 pushed a commit that referenced this pull request Jul 5, 2024
* feat: introduce a basic support for etags

* chore: fix tests

* chore: fix sonar

* Update packages/ui5-middleware-fe-mockserver/src/configResolver.ts

Co-authored-by: Dirk Teufel <50441133+drktfl@users.noreply.github.com>

---------

Co-authored-by: Dirk Teufel <50441133+drktfl@users.noreply.github.com>
otsquest101 added a commit that referenced this pull request Jul 8, 2024
* feat: handle changeset scenarios for 412 warnings

changes made to group  412 responses for  batch reqquest in changeset mode  with a single 412 error response
no changes required for isolated mode

* feat: introduce a basic support for etags (#828)

* feat: introduce a basic support for etags

* chore: fix tests

* chore: fix sonar

* Update packages/ui5-middleware-fe-mockserver/src/configResolver.ts

Co-authored-by: Dirk Teufel <50441133+drktfl@users.noreply.github.com>

---------

Co-authored-by: Dirk Teufel <50441133+drktfl@users.noreply.github.com>

* chore: apply latest changesets

* patch bump

* lint fixes

* resolve comments

---------

Co-authored-by: I569023 <abhishek.anand15@sap.com>
Co-authored-by: Nicolas Lunet <nicolas.lunet@sap.com>
Co-authored-by: Dirk Teufel <50441133+drktfl@users.noreply.github.com>
Co-authored-by: github-actions <github-actions@github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants