fix: app-id creation at scaffolding time in Component.js (fixes #70) #77
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- in Component.js template - accompanying test closes SAP#70
tobiasqueck
approved these changes
Sep 29, 2021
There was a problem hiding this comment.
- project installs, build and tests are running
- reported issue is fixed
- code is readable and linted
The same issue can also be found at https://github.com/SAP/open-ux-tools/blob/main/packages/ui5-application/src/data/defaults.ts#L37, however, this part of the code contains a few other issues, therefore, it needs to be reported as a separate issue.
devinea
added a commit
that referenced
this pull request
Oct 5, 2021
* main: update(FF): Updates FF Worklist controllers and tests (#63) fix: app-id creation at scaffolding time in Component.js (fixes #70) (#77) Add Node V16 build and compatibility (#64) chore: set version of all modules to v0.9.0 (#71) chore: add github codeowners file (#58) # Conflicts: # .github/workflows/pipeline.yml # packages/fiori-freestyle/package.json # pnpm-lock.yaml
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
replace all occurrences of "." with "/" in
Component.jstemplate