Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change: handling tar files in default conf file #46

Merged
merged 4 commits into from
Nov 6, 2020

Conversation

sumeetpatil
Copy link
Member

@sumeetpatil sumeetpatil commented Nov 3, 2020

Do not merge as we have to decide on the timestamp. Currently, the timestamp is hardcoded here.

@sumeetpatil sumeetpatil changed the title change: handling tar files in default conf file [DO_NOT_MERGE] change: handling tar files in default conf file Nov 3, 2020
@sumeetpatil sumeetpatil changed the title [DO_NOT_MERGE] change: handling tar files in default conf file change: handling tar files in default conf file Nov 6, 2020
@copernico
Copy link
Contributor

Hi @sumeetpatil , could you attach or paste a steady.sh file generated with this new config? That would simplify my review considerably. Thanks!

@sumeetpatil
Copy link
Member Author

Ok, here you go -> steady_script.txt

@copernico
Copy link
Contributor

An important consequence of this change is that the resulting file cannot be run anywere:

  1. it must be in the very same machine where kaybee merge was run
  2. the export must have been done immediately after the merge, or the data expected in the script might not be there (or might contain something different than they did when the export was executed)
  3. the file must be run from a very specific directory, or it won't find .kaybee/merged./....

The latter is easy to solve, not so much the other two...

@sumeetpatil
Copy link
Member Author

  1. If there is no data in .merge. We get this error -
> kaybee export -t steady                                                                                               
2020/11/06 14:45:04 open .kaybee/merged: no such file or directory
Exported 1 statements to steady.sh

But still, the steady.sh is generated. My latest commit will handle the case of generating any junk data.

  1. We can run it with specifying -f param like this -
    kaybee export -t steady -c project-kb/kaybeeconf.yaml -f project-kb/kaybee_backup/merged/CVE-2005-3745/statement.yaml

This would generate the script properly with the correct path. The script would contain something like this -
[ -f project-kb/kaybee_backup/merged/CVE-2005-3745/changed-source-code.tar.gz ] && tar -xf project-kb/kaybee_backup/merged/CVE-2005-3745/changed-source-code.tar.gz -C ./CVE-2005-3745

@copernico
Copy link
Contributor

I am not saying that kaybee export would not work, but that the resulting script steady.sh would not work in a machine where you do not have the necessary .kaybee/merged/.... directories. This may seem obvious, but this limitation did not exist before:
one could generate a steady.sh script which would be totally self-contained and self-sufficient to import data into any steady backend. You see what I mean?

@sumeetpatil
Copy link
Member Author

Ok, I understood

Copy link
Contributor

@copernico copernico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If the compressed archive with the source changes is missing this will fall-back to the old behaviour, that is good!

@copernico copernico merged commit c3fe384 into master Nov 6, 2020
@sumeetpatil sumeetpatil deleted the feature-change-conf branch November 10, 2020 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants