Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move out configurator properties from the core models #9177

Closed
Platonn opened this issue Oct 5, 2020 · 0 comments · Fixed by #9799
Closed

Move out configurator properties from the core models #9177

Platonn opened this issue Oct 5, 2020 · 0 comments · Fixed by #9799
Labels
features-libs
Projects
vc/Variant Config MVP
Milestone
vc/VariantConfig

Comments

@Platonn
Copy link
Contributor

Platonn commented Oct 5, 2020 •
edited
Loading

Some configurator-specific properties were added to the core models

  1. https://github.com/SAP/spartacus/pull/5347/files#diff-c211d412a5e819d5f24998f49a99c25b
    obraz

  2. https://github.com/SAP/spartacus/pull/5347/files#diff-9b9cde1756c4b7957926d07a42383d3f
    obraz

How to move it out:
@Platonn Platonn added this to the vc/VariantConfig milestone Oct 5, 2020
@Platonn Platonn self-assigned this Oct 5, 2020
@Larisa-Staroverova Larisa-Staroverova mentioned this issue Oct 23, 2020
Open
@ChristophHi ChristophHi moved this from ToDo to In Progress in vc/Variant Config MVP Oct 28, 2020
@ChristophHi ChristophHi assigned ChristophHi and unassigned Platonn Oct 28, 2020
@ChristophHi ChristophHi changed the title Move out configurator properties from the core models [Wait for #9176] Move out configurator properties from the core models Oct 28, 2020
@ChristophHi ChristophHi moved this from In Progress to ToDo in vc/Variant Config MVP Oct 28, 2020
@ChristophHi ChristophHi changed the title [Wait for #9176] Move out configurator properties from the core models Move out configurator properties from the core models Nov 16, 2020
@ChristophHi ChristophHi moved this from ToDo to In Progress in vc/Variant Config MVP Nov 16, 2020
ChristophHi added a commit that referenced this issue Nov 16, 2020
@ChristophHi
GH-9177 Clean up obsolete changes
be245cc
ChristophHi added a commit that referenced this issue Nov 16, 2020
@ChristophHi
GH-9177 Introduce type augmentation and remove obsolete changes
0755402
@ChristophHi ChristophHi linked a pull request Nov 17, 2020 that will close this issue
Feature/gh 9177 type augmentation and cleanup #9799
Merged
@ChristophHi ChristophHi moved this from In Progress to Code Review in vc/Variant Config MVP Nov 17, 2020
@ChristophHi ChristophHi removed their assignment Nov 17, 2020
ChristophHi added a commit that referenced this issue Nov 17, 2020
@ChristophHi
Merge branch 'epic/product-configuration' into feature/GH-9177-type-a…
f67606f 
…ugmentation-and-cleanup
ChristophHi added a commit that referenced this issue Nov 17, 2020
@ChristophHi
GH-9177 Remove unknown attribute in core test
87d5a12
@Larisa-Staroverova Larisa-Staroverova moved this from Code Review to Done in EPIC BRANCH in vc/Variant Config MVP Nov 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
features-libs
Projects
No open projects
vc/Variant Config MVP
  
Done
Milestone
vc/VariantConfig
Development

Successfully merging a pull request may close this issue.

Feature/gh 9177 type augmentation and cleanup SAP/spartacus
4 participants
@Platonn @ChristophHi @steinsebastian @Larisa-Staroverova