Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: Augment organization types in organization lib #9280

Merged
merged 19 commits into from
Oct 30, 2020
Merged

refactor: Augment organization types in organization lib #9280

merged 19 commits into from
Oct 30, 2020

Conversation

marlass
Copy link
Contributor

@marlass marlass commented Oct 9, 2020 •
edited
Loading

Organization models are now simpler in core library and augmented in the organization lib, where we need more properties on them.

Closes #8499
Closes #8876

@marlass
Copy link
Contributor Author

marlass commented Oct 9, 2020

QA steps:

  • augment CostCenter in the shell app with new property
  • try to create new object of this type in app (use properties from core declaration, my-account declaration and from the augmentation in the app) and then check TS compilation (build) and autocomplete (compilation should not throw anything and editor should recommend this property on this object.
  • try to use properties from my-account augmentation in core (compiler on core build should throw that the property is not defined on this model)

@cypress
Copy link

cypress bot commented Oct 9, 2020


Test summary

37 • 0 • 0 • 0

Run details
Project spartacus
Status Passed
Commit 6624904
Started Oct 9, 2020 9:25 AM
Ended Oct 9, 2020 9:28 AM
Duration 03:19 💡
OS Linux Ubuntu - 18.04
Browser Electron 83

View run in Cypress Dashboard ➡️

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

@cypress
Copy link

cypress bot commented Oct 9, 2020 •
edited
Loading


Test summary

37 • 0 • 0 • 0

Run details
Project spartacus
Status Passed
Commit 07c50b5a8a ℹ️
Started Oct 30, 2020 3:10 PM
Ended Oct 30, 2020 3:12 PM
Duration 02:32 💡
OS Linux Ubuntu - 18.04
Browser Electron 83

View run in Cypress Dashboard ➡️

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

dunqan
dunqan previously approved these changes Oct 9, 2020
View reviewed changes
@github-actions
Copy link
Contributor

github-actions bot commented Oct 14, 2020 •
edited
Loading

Public API change detection bot

@spartacus/assets public API diff

nothing changed ;)

@spartacus/storefront public API diff

nothing changed ;)

@spartacus/cds public API diff

nothing changed ;)

@spartacus/core public API diff

unable to analyze this library :(
Please check changes in public API manually.

@plabadie plabadie marked this pull request as ready for review October 19, 2020 15:08
@plabadie plabadie requested a review from a team October 19, 2020 15:08
@marlass marlass requested a review from dunqan October 20, 2020 09:42
@marlass marlass changed the title refactor: Augment CostCenter type in my-account refactor: Augment organization types in organization lib Oct 23, 2020
@Platonn Platonn mentioned this pull request Oct 23, 2020
Open
Platonn
Platonn previously approved these changes Oct 26, 2020
View reviewed changes
@Platonn Platonn mentioned this pull request Oct 27, 2020
Closed
@sonarcloud
Copy link

sonarcloud bot commented Oct 30, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@WeizhengSap WeizhengSap merged commit a181a2d into develop Oct 30, 2020
@WeizhengSap WeizhengSap deleted the feature/GH-8499 branch October 30, 2020 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@plabadie plabadie plabadie left review comments

@Platonn Platonn Platonn approved these changes

@dunqan dunqan Awaiting requested review from dunqan

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
5 participants
@marlass @Platonn @dunqan @plabadie @WeizhengSap