fix: 'this' is undefined in ProductEffects.productLoadEffect #17594
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kpawelczak
approved these changes
Jun 30, 2023
3 flaky tests on run #40914 ↗︎
Details:
|
|||||||||||||||||||||||||||
| Test | Artifacts | |
|---|---|---|
| SSR > should render homepage |
Output
Screenshots
|
|
| SSR > should render PLP |
Output
Screenshots
|
|
| SSR > should render PDP |
Output
Screenshots
|
|
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.
Platonn
added a commit
that referenced
this pull request
Jun 30, 2023
Previous behavior: When `/products` endpoint returned a http error, the code broke in [this line](https://github.com/SAP/spartacus/blob/ed1e1a78c488b1e1214491ffa736612287f8cf70/projects/core/src/product/store/effects/product.effect.ts#L77), complaining that `this` is undefined. Fix: Preserve the context of `this` which was lost in [this line](https://github.com/SAP/spartacus/blob/ed1e1a78c488b1e1214491ffa736612287f8cf70/projects/core/src/product/store/effects/product.effect.ts#L52) The problem was revealed only after we implemented [CXSPA-2251](https://jira.tools.sap/browse/CXSPA-2251) where we referenced `this` by adding `this.logger` to the method `ProductEffects.productLoadEffect` fixes https://jira.tools.sap/browse/CXSPA-3902
kpawelczak
pushed a commit
that referenced
this pull request
Jul 10, 2023
Previous behavior: When `/products` endpoint returned a http error, the code broke in [this line](https://github.com/SAP/spartacus/blob/ed1e1a78c488b1e1214491ffa736612287f8cf70/projects/core/src/product/store/effects/product.effect.ts#L77), complaining that `this` is undefined. Fix: Preserve the context of `this` which was lost in [this line](https://github.com/SAP/spartacus/blob/ed1e1a78c488b1e1214491ffa736612287f8cf70/projects/core/src/product/store/effects/product.effect.ts#L52) The problem was revealed only after we implemented [CXSPA-2251](https://jira.tools.sap/browse/CXSPA-2251) where we referenced `this` by adding `this.logger` to the method `ProductEffects.productLoadEffect` fixes https://jira.tools.sap/browse/CXSPA-3902
kpawelczak
pushed a commit
that referenced
this pull request
Jul 11, 2023
Previous behavior: When `/products` endpoint returned a http error, the code broke in [this line](https://github.com/SAP/spartacus/blob/ed1e1a78c488b1e1214491ffa736612287f8cf70/projects/core/src/product/store/effects/product.effect.ts#L77), complaining that `this` is undefined. Fix: Preserve the context of `this` which was lost in [this line](https://github.com/SAP/spartacus/blob/ed1e1a78c488b1e1214491ffa736612287f8cf70/projects/core/src/product/store/effects/product.effect.ts#L52) The problem was revealed only after we implemented [CXSPA-2251](https://jira.tools.sap/browse/CXSPA-2251) where we referenced `this` by adding `this.logger` to the method `ProductEffects.productLoadEffect` fixes https://jira.tools.sap/browse/CXSPA-3902
AshreeJay
added a commit
that referenced
this pull request
Jul 17, 2023
commit 8dd2926 Merge: 7807b33 6d5b7ba Author: AshreeJay <52031769+AshreeJay@users.noreply.github.com> Date: Tue Jul 11 15:56:03 2023 +0530 Merge branch 'develop-6.2.x' into CDP-integration commit 6d5b7ba Author: Krzysztof Platis <platonn.git@gmail.com> Date: Fri Jun 30 12:24:42 2023 +0200 fix: 'this' is undefined in ProductEffects.productLoadEffect (#17594) Previous behavior: When `/products` endpoint returned a http error, the code broke in [this line](https://github.com/SAP/spartacus/blob/ed1e1a78c488b1e1214491ffa736612287f8cf70/projects/core/src/product/store/effects/product.effect.ts#L77), complaining that `this` is undefined. Fix: Preserve the context of `this` which was lost in [this line](https://github.com/SAP/spartacus/blob/ed1e1a78c488b1e1214491ffa736612287f8cf70/projects/core/src/product/store/effects/product.effect.ts#L52) The problem was revealed only after we implemented [CXSPA-2251](https://jira.tools.sap/browse/CXSPA-2251) where we referenced `this` by adding `this.logger` to the method `ProductEffects.productLoadEffect` fixes https://jira.tools.sap/browse/CXSPA-3902 commit ed1e1a7 Author: Paweł Fraś <fras.pawel@yahoo.com> Date: Wed Jun 28 08:30:42 2023 +0200 chore: CXSPA-3794 - SSR contextual logging extensibility (#17578) commit 47346c7 Author: Christoph Hinssen <33626130+ChristophHi@users.noreply.github.com> Date: Tue Jun 27 13:54:21 2023 +0200 fix: configurator restart must remove UI state as well (#17581) See https://jira.tools.sap/browse/CXSPA-3839 commit f3d508b Author: niehuayang <126219214+niehuayang@users.noreply.github.com> Date: Tue Jun 27 15:52:10 2023 +0800 fix/CXSPA-3848: cherry-pick buf fixes from branch 6.1.x to branch 6.2.x (#17579) commit cfa7efd Author: Grace Dong <127385561+i53577@users.noreply.github.com> Date: Tue Jun 27 14:21:02 2023 +0800 fix: Need to adapt to the width of mobile webpage on CustomerList (#17576) commit eebc403 Author: luoyifeng11 <127297696+luoyifeng11@users.noreply.github.com> Date: Fri Jun 23 15:16:32 2023 +0800 test: fix ASM E2E test instability for 6.2 (#17569) commit 05cc70b Author: Scar Ai <38693320+scarai-sap@users.noreply.github.com> Date: Fri Jun 23 13:17:38 2023 +0800 feat: update text as UX suggested #17522 for 6.2 (#17565) commit 4464f61 Author: Paweł Fraś <fras.pawel@yahoo.com> Date: Thu Jun 22 16:07:07 2023 +0200 feat: CXSPA-3742 - SSR logging - addresing minor comments (#17538) commit 23e537e Author: luoyifeng11 <127297696+luoyifeng11@users.noreply.github.com> Date: Thu Jun 22 21:26:33 2023 +0800 test: Fix the instability issue in ASM E2E tests, as well as the failure issue in asm-cost-center.e2e (#17487) commit 88d56e6 Author: i333055 <lulu.ran@sap.com> Date: Wed Jun 21 15:09:14 2023 +0800 fix: add jira num for e2e tests (#17552) commit 5f64005 Author: anjana-bl <84384970+anjana-bl@users.noreply.github.com> Date: Wed Jun 21 11:03:11 2023 +0530 cdc consent management - review changes (#17546) commit 615e4fe Author: i333055 <lulu.ran@sap.com> Date: Wed Jun 21 12:40:37 2023 +0800 fix: display confirm switch customer dialog when new customerId in the deeplink (#17530) Co-authored-by: Scar Ai <38693320+scarai-sap@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Hak Woo Kim <kimhakwoo@hotmail.com> Co-authored-by: Caine Rotherham <rotherham.c@gmail.com> Co-authored-by: Scar Ai <scar.ai@sap.com> Co-authored-by: niehuayang <126219214+niehuayang@users.noreply.github.com> Co-authored-by: Giancarlo Cordero Ortiz <46171897+giancorderoortiz@users.noreply.github.com> commit a66ff46 Author: steinsebastian <54309425+steinsebastian@users.noreply.github.com> Date: Tue Jun 20 14:41:25 2023 +0200 fix: accessibilty for read-only attributes (#17537) commit 5a981f0 Author: niehuayang <126219214+niehuayang@users.noreply.github.com> Date: Tue Jun 20 15:58:18 2023 +0800 refine busy icon diaplay for ASM crerate new customer (#17533) commit 235f37e Author: Mohit Sisodiya <122589468+sisodiyam@users.noreply.github.com> Date: Tue Jun 20 11:09:59 2023 +0530 CXINT-1833: added the cypress test for the register organization (#17505) Co-authored-by: anjana-bl <anjana.b.l@sap.com> commit 0a0f19f Author: Radhep Sabapathipillai <34665674+RadhepS@users.noreply.github.com> Date: Mon Jun 19 16:35:33 2023 -0400 Release 6.2.0-1 commit 7807b33 Author: Akash Srivastava <akash.srivastava05@sap.com> Date: Tue Apr 25 13:45:28 2023 +0530 Doing changes for return order commit b89b0cf Merge: 83550c7 e93ba2f Author: Akash Srivastava <akash.srivastava05@sap.com> Date: Tue Apr 18 16:40:19 2023 +0530 Merge branch 'CDP-integration' of https://github.com/SAP/spartacus into CDP-integration commit e93ba2f Author: Akash-SAP <125430597+Akash-SAP@users.noreply.github.com> Date: Tue Apr 18 16:35:09 2023 +0530 Changes related to return and spinner (#17292) * service request side navigation changes * Update environment.ts * Add license header * Update environment.ts * Pushing changes for return fix * Spinner No Order Issue --------- Co-authored-by: AshreeJay <52031769+AshreeJay@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> commit 83550c7 Merge: 2b9e054 2a57167 Author: Akash Srivastava <akash.srivastava05@sap.com> Date: Tue Apr 18 16:26:48 2023 +0530 Merge branch 'CDP-integration' of https://github.com/SAP/spartacus into CDP-integration commit 2a57167 Author: AshreeJay <52031769+AshreeJay@users.noreply.github.com> Date: Tue Apr 18 10:20:55 2023 +0530 CXINT 1638 body content : Customer Service request Changes (#17291) * service request side navigation changes * Update environment.ts * Add license header * Update environment.ts --------- Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> commit f0e3c13 Merge: 2caad70 c89f586 Author: anjana-bl <anjana.b.l@sap.com> Date: Thu Apr 13 16:11:05 2023 +0530 Merge branch 'develop' into CDP-integration commit 2b9e054 Merge: fd8f390 44a4294 Author: Akash Srivastava <akash.srivastava05@sap.com> Date: Thu Apr 13 15:20:32 2023 +0530 Merge branch 'CXINT-1638-bodyContent' into CDP-integration commit 2caad70 Merge: 3844524 44a4294 Author: AshreeJay <52031769+AshreeJay@users.noreply.github.com> Date: Thu Apr 13 15:07:13 2023 +0530 Merge branch 'CXINT-1638-bodyContent' into CDP-integration commit 3844524 Merge: fd8f390 b273a3d Author: AshreeJay <52031769+AshreeJay@users.noreply.github.com> Date: Thu Apr 13 15:04:56 2023 +0530 Merge branch 'CXINT-1638-bodyContent' into CDP-integration commit 44a4294 Author: Akash Srivastava <akash.srivastava05@sap.com> Date: Thu Apr 13 14:47:25 2023 +0530 Return order changes as per new return response commit 7218334 Author: Akash Srivastava <akash.srivastava05@sap.com> Date: Wed Apr 12 19:46:28 2023 +0530 Pushing The Changes for Return Order commit d80fdb7 Merge: 9e6b0e7 b273a3d Author: Akash Srivastava <akash.srivastava05@sap.com> Date: Wed Apr 12 19:25:43 2023 +0530 Merge branch 'CXINT-1638-bodyContent' of https://github.com/SAP/spartacus into CXINT-1638-bodyContent commit 9e6b0e7 Author: Akash Srivastava <akash.srivastava05@sap.com> Date: Wed Apr 12 16:58:43 2023 +0530 Changes of return and for demo commit fd8f390 Author: AshreeJay <52031769+AshreeJay@users.noreply.github.com> Date: Tue Apr 11 16:34:36 2023 +0530 CXINT-1638 body content (#17228) * generated lib cdp * update configs * update config * created login service * update login.component.service.ts * added cdp-login-component * removed service * added cdp-my-account component * update * update * update * update * update * update * update * update * CXINT-1634-Order Changes for order histroy page * update * update * update * update * CXINT-1807: Doing changes for showing images * update * Changes for css * update * update * Revert "update" This reverts commit 590432a. * resolved conflicts * update * Changes for image in order history * myAccount changes * update * update * update * update * Changes for spinner and images * update * update * Update cdp-my-account.component.html * update * MyAccount button changes * update * changes for image * Added Page Size * css changes * Doing Code Refactoring * css changes * feat: add buy online, pickup in store functionality (#17080) Introduces new components and associated functionality to enable Buy Online, Pick Up in Store. BREAKING CHANGE: The `AddToCartComponent` contains new logic for Buy Online, Pick Up in Store. * chore: Generate default Spartacus 6 migrations (#17082) added default spartacus 6 migrations * docs: Update breaking changes for add to cart component (#17086) * fix: ignore reviewPage interceptor response as hotfix (#17036) * css changes * update cdp.ts * Update cdp-my-account.component.ts * removed unwanted files * removed unwanted files * folder changes * folder changes * removed unwanted files * folder changes * folder changes * Update cdp-my-account.component.html * update user title with a condition * update route for Personal Details * update * UPDATE * chore: correct CODEOWNERS for BOPIS * fix(Bopis feature module should not be enabled for b2b users) (#17097) * test: improve unit tests of I18nextHttpBackendInitializer (#17083) - add test for using `i18next-http-backend` plugin - add tests for `hasMatch` method btw. removed redundant service's name from the error message related to https://jira.tools.sap/browse/CXSPA-2866 * chore: Excluding BOPIS e2e tests from core tests * fix: Adhere to checkmarx issues for bopis feature (#17087) (#17088) fixes checkmarx issues for bopis feature * fix: Remove unwanted pickup store address block on order history page (#17100) * chore: CI validation script changes - Fixing typo in folder name - Removing '.only' from spec file - Adding prettier.log to gitignore * fix: remove unused BOPIS dependencies (#17096) While BOPIS depends on store finder, order, and user, these are compile-time dependencies so do not need to be included in the config. * Destroy Subscribes when finished (#17098) * Destroy Subscribes when finished * Define type for IOutletContextData * chore(deps-dev): bump webpack from 5.75.0 to 5.76.0 (#17047) Bumps [webpack](https://github.com/webpack/webpack) from 5.75.0 to 5.76.0. - [Release notes](https://github.com/webpack/webpack/releases) - [Commits](webpack/webpack@v5.75.0...v5.76.0) --- updated-dependencies: - dependency-name: webpack dependency-type: direct:development ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Giancarlo Cordero Ortiz <46171897+giancorderoortiz@users.noreply.github.com> * removed unwanted lines * lib changes and css * removed unwanted files * Update cdp-my-account-side-navigation.component.ts * removed unwanted * Revert "Update cdp-my-account-side-navigation.component.ts" This reverts commit c0cc98c. * Update cdp-my-account-side-navigation.component.ts * file changes after yarn config update and yarn generate deps * page template css changes * Add license header * Update cdp.ts * fixed config check failure * fixed check config * npm config update changes * Update package.json * logOut route fix * added order.status * added "No Orders" template * Update cdp-my-account-side-navigation.module.ts * config changes * added routes * disabled Customer Service * Sprint demo changes * CDP order Horizontal line changes * Order page when no order is present * added default logout route * Update cdp-my-account.component.html * Update tsconfig.schematics.json * Refactoring the code structure * Update environment.ts * update service in cdp-my-account.component.ts * multiple api call fix for order details * Add license header * multiImage fix --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: Akash Srivastava <akash.srivastava05@sap.com> Co-authored-by: Surya Prakash <101825663+surya-prakash-singh1@users.noreply.github.com> Co-authored-by: Brian Gamboc-Javiniar <brian_javiniar@hotmail.com> Co-authored-by: JedidiahAwuku <109527259+JedidiahAwuku@users.noreply.github.com> Co-authored-by: Florent Letendre <florent.letendre01@sap.com> Co-authored-by: Sam Vendittelli <sam.vendittelli@sap.com> Co-authored-by: Krzysztof Platis <platonn.git@gmail.com> Co-authored-by: Gilberto Alvarado <gilberto.alvarado.jimenez@sap.com> Co-authored-by: cawmichae <50734654+cawmichae@users.noreply.github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Giancarlo Cordero Ortiz <46171897+giancorderoortiz@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> commit b273a3d Merge: c8043b4 8a74a5b Author: AshreeJay <52031769+AshreeJay@users.noreply.github.com> Date: Tue Apr 11 16:28:18 2023 +0530 Merge branch 'CXINT-1638-bodyContent' of https://github.com/SAP/spartacus into CXINT-1638-bodyContent commit c8043b4 Author: AshreeJay <52031769+AshreeJay@users.noreply.github.com> Date: Tue Apr 11 16:28:02 2023 +0530 multiImage fix commit 8a74a5b Author: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Date: Tue Apr 11 08:48:07 2023 +0000 Add license header commit ec8e47c Merge: 7052808 1ab3c46 Author: AshreeJay <52031769+AshreeJay@users.noreply.github.com> Date: Tue Apr 11 14:16:42 2023 +0530 Merge branch 'CDP-integration' into CXINT-1638-bodyContent commit 7052808 Author: AshreeJay <52031769+AshreeJay@users.noreply.github.com> Date: Tue Apr 11 14:12:23 2023 +0530 multiple api call fix for order details commit 19cb4e2 Author: AshreeJay <52031769+AshreeJay@users.noreply.github.com> Date: Tue Apr 11 13:44:58 2023 +0530 update service in cdp-my-account.component.ts commit a276f07 Author: AshreeJay <52031769+AshreeJay@users.noreply.github.com> Date: Wed Apr 5 15:32:36 2023 +0530 Update environment.ts commit 1ab3c46 Author: AshreeJay <52031769+AshreeJay@users.noreply.github.com> Date: Wed Apr 5 11:13:46 2023 +0530 icon changes commit 6a62a1c Merge: 55b3298 2a55735 Author: Akash Srivastava <akash.srivastava05@sap.com> Date: Mon Apr 3 15:31:32 2023 +0530 Merge branch 'CXINT-1638-bodyContent' of https://github.com/SAP/spartacus into CXINT-1638-bodyContent commit 55b3298 Author: Akash Srivastava <akash.srivastava05@sap.com> Date: Mon Apr 3 15:29:58 2023 +0530 Refactoring the code structure commit 41def02 Author: AshreeJay <52031769+AshreeJay@users.noreply.github.com> Date: Mon Apr 3 13:22:57 2023 +0530 CXINT 1638 body content (#17113) * generated lib cdp * update configs * update config * created login service * update login.component.service.ts * added cdp-login-component * removed service * added cdp-my-account component * update * update * update * update * update * update * update * update * CXINT-1634-Order Changes for order histroy page * update * update * update * update * CXINT-1807: Doing changes for showing images * update * Changes for css * update * update * Revert "update" This reverts commit 590432a. * resolved conflicts * update * Changes for image in order history * myAccount changes * update * update * update * update * Changes for spinner and images * update * update * Update cdp-my-account.component.html * update * MyAccount button changes * update * changes for image * Added Page Size * css changes * Doing Code Refactoring * css changes * feat: add buy online, pickup in store functionality (#17080) Introduces new components and associated functionality to enable Buy Online, Pick Up in Store. BREAKING CHANGE: The `AddToCartComponent` contains new logic for Buy Online, Pick Up in Store. * chore: Generate default Spartacus 6 migrations (#17082) added default spartacus 6 migrations * docs: Update breaking changes for add to cart component (#17086) * fix: ignore reviewPage interceptor response as hotfix (#17036) * css changes * update cdp.ts * Update cdp-my-account.component.ts * removed unwanted files * removed unwanted files * folder changes * folder changes * removed unwanted files * folder changes * folder changes * Update cdp-my-account.component.html * update user title with a condition * update route for Personal Details * update * UPDATE * chore: correct CODEOWNERS for BOPIS * fix(Bopis feature module should not be enabled for b2b users) (#17097) * test: improve unit tests of I18nextHttpBackendInitializer (#17083) - add test for using `i18next-http-backend` plugin - add tests for `hasMatch` method btw. removed redundant service's name from the error message related to https://jira.tools.sap/browse/CXSPA-2866 * chore: Excluding BOPIS e2e tests from core tests * fix: Adhere to checkmarx issues for bopis feature (#17087) (#17088) fixes checkmarx issues for bopis feature * fix: Remove unwanted pickup store address block on order history page (#17100) * chore: CI validation script changes - Fixing typo in folder name - Removing '.only' from spec file - Adding prettier.log to gitignore * fix: remove unused BOPIS dependencies (#17096) While BOPIS depends on store finder, order, and user, these are compile-time dependencies so do not need to be included in the config. * Destroy Subscribes when finished (#17098) * Destroy Subscribes when finished * Define type for IOutletContextData * chore(deps-dev): bump webpack from 5.75.0 to 5.76.0 (#17047) Bumps [webpack](https://github.com/webpack/webpack) from 5.75.0 to 5.76.0. - [Release notes](https://github.com/webpack/webpack/releases) - [Commits](webpack/webpack@v5.75.0...v5.76.0) --- updated-dependencies: - dependency-name: webpack dependency-type: direct:development ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Giancarlo Cordero Ortiz <46171897+giancorderoortiz@users.noreply.github.com> * removed unwanted lines * lib changes and css * removed unwanted files * Update cdp-my-account-side-navigation.component.ts * removed unwanted * Revert "Update cdp-my-account-side-navigation.component.ts" This reverts commit c0cc98c. * Update cdp-my-account-side-navigation.component.ts * file changes after yarn config update and yarn generate deps * page template css changes * Add license header * Update cdp.ts * fixed config check failure * fixed check config * npm config update changes * Update package.json * logOut route fix * added order.status * added "No Orders" template * Update cdp-my-account-side-navigation.module.ts * config changes * added routes * disabled Customer Service * Sprint demo changes * CDP order Horizontal line changes * added default logout route * Update cdp-my-account.component.html * Update tsconfig.schematics.json --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: Akash Srivastava <akash.srivastava05@sap.com> Co-authored-by: Surya Prakash <101825663+surya-prakash-singh1@users.noreply.github.com> Co-authored-by: Brian Gamboc-Javiniar <brian_javiniar@hotmail.com> Co-authored-by: JedidiahAwuku <109527259+JedidiahAwuku@users.noreply.github.com> Co-authored-by: Florent Letendre <florent.letendre01@sap.com> Co-authored-by: Sam Vendittelli <sam.vendittelli@sap.com> Co-authored-by: Krzysztof Platis <platonn.git@gmail.com> Co-authored-by: Gilberto Alvarado <gilberto.alvarado.jimenez@sap.com> Co-authored-by: cawmichae <50734654+cawmichae@users.noreply.github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Giancarlo Cordero Ortiz <46171897+giancorderoortiz@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> commit 2a55735 Author: AshreeJay <52031769+AshreeJay@users.noreply.github.com> Date: Mon Apr 3 13:22:36 2023 +0530 Update tsconfig.schematics.json commit e19720d Merge: 5f5c32e b291b3b Author: AshreeJay <52031769+AshreeJay@users.noreply.github.com> Date: Mon Apr 3 13:20:06 2023 +0530 Merge branch 'CDP-integration' into CXINT-1638-bodyContent commit 5f5c32e Author: AshreeJay <52031769+AshreeJay@users.noreply.github.com> Date: Mon Apr 3 13:15:09 2023 +0530 Update cdp-my-account.component.html commit b9a8561 Merge: d250f4c f024743 Author: AshreeJay <52031769+AshreeJay@users.noreply.github.com> Date: Mon Apr 3 12:41:11 2023 +0530 Merge branch 'CXINT-1638-bodyContent' of https://github.com/SAP/spartacus into CXINT-1638-bodyContent commit d250f4c Author: AshreeJay <52031769+AshreeJay@users.noreply.github.com> Date: Mon Apr 3 12:09:57 2023 +0530 added default logout route commit 852dcbd Author: Akash Srivastava <akash.srivastava05@sap.com> Date: Wed Mar 29 16:00:17 2023 +0530 Order page when no order is present commit f024743 Merge: 0bc1758 1ed7b52 Author: Akash Srivastava <akash.srivastava05@sap.com> Date: Tue Mar 28 14:51:10 2023 +0530 Merge branch 'CXINT-1638-bodyContent' of https://github.com/SAP/spartacus into CXINT-1638-bodyContent commit 0bc1758 Author: Akash Srivastava <akash.srivastava05@sap.com> Date: Tue Mar 28 14:50:09 2023 +0530 CDP order Horizontal line changes commit b291b3b Author: anjana-bl <84384970+anjana-bl@users.noreply.github.com> Date: Tue Mar 28 14:18:08 2023 +0530 My account update personal details - v1 (#17141) * Update Personal Details * npm config:update commit 1ed7b52 Author: AshreeJay <52031769+AshreeJay@users.noreply.github.com> Date: Mon Mar 27 09:32:27 2023 +0530 Sprint demo changes commit c36be6a Author: AshreeJay <52031769+AshreeJay@users.noreply.github.com> Date: Sat Mar 25 13:31:23 2023 +0530 disabled Customer Service commit 267d9e3 Author: AshreeJay <52031769+AshreeJay@users.noreply.github.com> Date: Sat Mar 25 13:30:10 2023 +0530 added routes commit d2bd9f9 Author: AshreeJay <52031769+AshreeJay@users.noreply.github.com> Date: Sat Mar 25 13:17:50 2023 +0530 config changes commit 37368f0 Author: AshreeJay <52031769+AshreeJay@users.noreply.github.com> Date: Fri Mar 24 12:15:45 2023 +0530 Update cdp-my-account-side-navigation.module.ts commit 940d5ab Author: AshreeJay <52031769+AshreeJay@users.noreply.github.com> Date: Fri Mar 24 11:27:55 2023 +0530 added "No Orders" template commit f7c7b8e Merge: e8c9df4 8f9ea15 Author: AshreeJay <52031769+AshreeJay@users.noreply.github.com> Date: Thu Mar 23 16:37:29 2023 +0530 update commit e8c9df4 Author: AshreeJay <52031769+AshreeJay@users.noreply.github.com> Date: Thu Mar 23 16:19:56 2023 +0530 added order.status commit 893da53 Author: AshreeJay <52031769+AshreeJay@users.noreply.github.com> Date: Thu Mar 23 15:49:55 2023 +0530 logOut route fix commit 8f9ea15 Author: AshreeJay <52031769+AshreeJay@users.noreply.github.com> Date: Thu Mar 23 14:36:15 2023 +0530 CXINT-1638 My Account Changes (#17111) * generated lib cdp * update configs * update config * created login service * update login.component.service.ts * added cdp-login-component * removed service * added cdp-my-account component * update * update * update * update * update * update * update * update * CXINT-1634-Order Changes for order histroy page * update * update * update * update * CXINT-1807: Doing changes for showing images * update * Changes for css * update * update * Revert "update" This reverts commit 590432a. * resolved conflicts * update * Changes for image in order history * myAccount changes * update * update * update * update * Changes for spinner and images * update * update * Update cdp-my-account.component.html * update * MyAccount button changes * update * changes for image * Added Page Size * css changes * Doing Code Refactoring * css changes * feat: add buy online, pickup in store functionality (#17080) Introduces new components and associated functionality to enable Buy Online, Pick Up in Store. BREAKING CHANGE: The `AddToCartComponent` contains new logic for Buy Online, Pick Up in Store. * chore: Generate default Spartacus 6 migrations (#17082) added default spartacus 6 migrations * docs: Update breaking changes for add to cart component (#17086) * fix: ignore reviewPage interceptor response as hotfix (#17036) * css changes * update cdp.ts * Update cdp-my-account.component.ts * removed unwanted files * removed unwanted files * folder changes * folder changes * removed unwanted files * folder changes * folder changes * Update cdp-my-account.component.html * update user title with a condition * update route for Personal Details * update * UPDATE * chore: correct CODEOWNERS for BOPIS * fix(Bopis feature module should not be enabled for b2b users) (#17097) * test: improve unit tests of I18nextHttpBackendInitializer (#17083) - add test for using `i18next-http-backend` plugin - add tests for `hasMatch` method btw. removed redundant service's name from the error message related to https://jira.tools.sap/browse/CXSPA-2866 * chore: Excluding BOPIS e2e tests from core tests * fix: Adhere to checkmarx issues for bopis feature (#17087) (#17088) fixes checkmarx issues for bopis feature * fix: Remove unwanted pickup store address block on order history page (#17100) * chore: CI validation script changes - Fixing typo in folder name - Removing '.only' from spec file - Adding prettier.log to gitignore * fix: remove unused BOPIS dependencies (#17096) While BOPIS depends on store finder, order, and user, these are compile-time dependencies so do not need to be included in the config. * Destroy Subscribes when finished (#17098) * Destroy Subscribes when finished * Define type for IOutletContextData * chore(deps-dev): bump webpack from 5.75.0 to 5.76.0 (#17047) Bumps [webpack](https://github.com/webpack/webpack) from 5.75.0 to 5.76.0. - [Release notes](https://github.com/webpack/webpack/releases) - [Commits](webpack/webpack@v5.75.0...v5.76.0) --- updated-dependencies: - dependency-name: webpack dependency-type: direct:development ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Giancarlo Cordero Ortiz <46171897+giancorderoortiz@users.noreply.github.com> * removed unwanted lines * lib changes and css * removed unwanted files * Update cdp-my-account-side-navigation.component.ts * removed unwanted * Revert "Update cdp-my-account-side-navigation.component.ts" This reverts commit c0cc98c. * Update cdp-my-account-side-navigation.component.ts * file changes after yarn config update and yarn generate deps * page template css changes * Add license header * Update cdp.ts * fixed config check failure * fixed check config * npm config update changes * Update package.json --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: Akash Srivastava <akash.srivastava05@sap.com> Co-authored-by: Surya Prakash <101825663+surya-prakash-singh1@users.noreply.github.com> Co-authored-by: Brian Gamboc-Javiniar <brian_javiniar@hotmail.com> Co-authored-by: JedidiahAwuku <109527259+JedidiahAwuku@users.noreply.github.com> Co-authored-by: Florent Letendre <florent.letendre01@sap.com> Co-authored-by: Sam Vendittelli <sam.vendittelli@sap.com> Co-authored-by: Krzysztof Platis <platonn.git@gmail.com> Co-authored-by: Gilberto Alvarado <gilberto.alvarado.jimenez@sap.com> Co-authored-by: cawmichae <50734654+cawmichae@users.noreply.github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Giancarlo Cordero Ortiz <46171897+giancorderoortiz@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> commit a7b76c0 Author: AshreeJay <52031769+AshreeJay@users.noreply.github.com> Date: Thu Mar 23 14:35:07 2023 +0530 Update package.json commit 3a40516 Author: AshreeJay <52031769+AshreeJay@users.noreply.github.com> Date: Thu Mar 23 14:23:38 2023 +0530 npm config update changes commit 12ef3be Author: AshreeJay <52031769+AshreeJay@users.noreply.github.com> Date: Thu Mar 23 13:48:15 2023 +0530 fixed check config commit 75123a0 Merge: a837dd9 3150c08 Author: AshreeJay <52031769+AshreeJay@users.noreply.github.com> Date: Thu Mar 23 13:18:03 2023 +0530 Merge branch 'CXINT-1638-bodyContent' of https://github.com/SAP/spartacus into CXINT-1638-bodyContent commit a837dd9 Author: AshreeJay <52031769+AshreeJay@users.noreply.github.com> Date: Thu Mar 23 13:18:00 2023 +0530 fixed config check failure commit 20089e1 Author: AshreeJay <52031769+AshreeJay@users.noreply.github.com> Date: Thu Mar 23 13:12:20 2023 +0530 Update cdp.ts commit 3150c08 Author: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Date: Thu Mar 23 07:39:45 2023 +0000 Add license header commit c5a2865 Author: AshreeJay <52031769+AshreeJay@users.noreply.github.com> Date: Thu Mar 23 12:53:46 2023 +0530 page template css changes commit 5980f80 Author: AshreeJay <52031769+AshreeJay@users.noreply.github.com> Date: Thu Mar 23 12:48:01 2023 +0530 file changes after yarn config update and yarn generate deps commit 2a14668 Merge: d27e255 4256525 Author: AshreeJay <52031769+AshreeJay@users.noreply.github.com> Date: Thu Mar 23 12:19:39 2023 +0530 Merge branch 'develop' into CXINT-1638-bodyContent commit d27e255 Author: AshreeJay <52031769+AshreeJay@users.noreply.github.com> Date: Thu Mar 23 12:15:19 2023 +0530 Update cdp-my-account-side-navigation.component.ts commit a1d8048 Author: AshreeJay <52031769+AshreeJay@users.noreply.github.com> Date: Thu Mar 23 12:11:35 2023 +0530 Revert "Update cdp-my-account-side-navigation.component.ts" This reverts commit c0cc98c. commit c4dad7e Author: AshreeJay <52031769+AshreeJay@users.noreply.github.com> Date: Thu Mar 23 12:06:50 2023 +0530 removed unwanted commit c0cc98c Author: AshreeJay <52031769+AshreeJay@users.noreply.github.com> Date: Thu Mar 23 12:04:48 2023 +0530 Update cdp-my-account-side-navigation.component.ts commit 4dfdeed Author: AshreeJay <52031769+AshreeJay@users.noreply.github.com> Date: Thu Mar 23 11:58:00 2023 +0530 removed unwanted files commit 6131e4f Author: AshreeJay <52031769+AshreeJay@users.noreply.github.com> Date: Thu Mar 23 11:23:30 2023 +0530 lib changes and css commit 123bdaf Author: AshreeJay <52031769+AshreeJay@users.noreply.github.com> Date: Thu Mar 23 10:50:10 2023 +0530 removed unwanted lines commit fe56770 Author: AshreeJay <52031769+AshreeJay@users.noreply.github.com> Date: Wed Mar 22 16:09:21 2023 +0530 UPDATE commit 0cb6440 Author: AshreeJay <52031769+AshreeJay@users.noreply.github.com> Date: Wed Mar 22 15:52:45 2023 +0530 update commit df35480 Author: AshreeJay <52031769+AshreeJay@users.noreply.github.com> Date: Wed Mar 22 15:38:33 2023 +0530 update route for Personal Details commit ea45f2c Author: AshreeJay <52031769+AshreeJay@users.noreply.github.com> Date: Wed Mar 22 15:33:00 2023 +0530 update user title with a condition commit d9a9998 Author: AshreeJay <52031769+AshreeJay@users.noreply.github.com> Date: Wed Mar 22 15:05:14 2023 +0530 Update cdp-my-account.component.html commit 222be7a Author: AshreeJay <52031769+AshreeJay@users.noreply.github.com> Date: Wed Mar 22 14:57:01 2023 +0530 folder changes commit 40f4178 Author: AshreeJay <52031769+AshreeJay@users.noreply.github.com> Date: Wed Mar 22 14:12:38 2023 +0530 folder changes commit b463189 Author: AshreeJay <52031769+AshreeJay@users.noreply.github.com> Date: Wed Mar 22 13:57:15 2023 +0530 removed unwanted files commit 0e667d5 Author: AshreeJay <52031769+AshreeJay@users.noreply.github.com> Date: Wed Mar 22 13:34:09 2023 +0530 folder changes commit f450e1b Author: AshreeJay <52031769+AshreeJay@users.noreply.github.com> Date: Wed Mar 22 13:32:17 2023 +0530 folder changes commit e28f45d Author: AshreeJay <52031769+AshreeJay@users.noreply.github.com> Date: Wed Mar 22 13:10:01 2023 +0530 removed unwanted files commit 04d89d6 Author: AshreeJay <52031769+AshreeJay@users.noreply.github.com> Date: Wed Mar 22 13:02:18 2023 +0530 removed unwanted files commit eefc39a Author: AshreeJay <52031769+AshreeJay@users.noreply.github.com> Date: Wed Mar 22 12:43:02 2023 +0530 Update cdp-my-account.component.ts commit 5e74f19 Merge: a577cfb 091da48 Author: AshreeJay <52031769+AshreeJay@users.noreply.github.com> Date: Wed Mar 22 12:25:12 2023 +0530 Merge branch 'CXINT-1638-bodyContent' of https://github.com/SAP/spartacus into CXINT-1638-bodyContent commit a577cfb Author: AshreeJay <52031769+AshreeJay@users.noreply.github.com> Date: Wed Mar 22 12:18:41 2023 +0530 update cdp.ts commit 286726e Author: AshreeJay <52031769+AshreeJay@users.noreply.github.com> Date: Wed Mar 22 11:50:56 2023 +0530 css changes commit ab61a63 Author: AshreeJay <52031769+AshreeJay@users.noreply.github.com> Date: Tue Mar 21 16:59:33 2023 +0530 css changes commit 091da48 Merge: ab97da7 ec06241 Author: Akash Srivastava <akash.srivastava05@sap.com> Date: Tue Mar 21 13:32:02 2023 +0530 Merge branch 'CXINT-1638-bodyContent' of https://github.com/SAP/spartacus into CXINT-1638-bodyContent commit ab97da7 Author: Akash Srivastava <akash.srivastava05@sap.com> Date: Tue Mar 21 13:27:32 2023 +0530 Doing Code Refactoring commit ec06241 Author: AshreeJay <52031769+AshreeJay@users.noreply.github.com> Date: Tue Mar 21 13:15:37 2023 +0530 css changes commit 06db319 Author: AshreeJay <52031769+AshreeJay@users.noreply.github.com> Date: Mon Mar 20 10:58:55 2023 +0530 Added Page Size commit ebc62ae Author: Akash Srivastava <akash.srivastava05@sap.com> Date: Fri Mar 17 14:41:14 2023 +0530 changes for image commit c2de458 Author: AshreeJay <52031769+AshreeJay@users.noreply.github.com> Date: Fri Mar 17 13:55:47 2023 +0530 update commit 58f32dc Author: AshreeJay <52031769+AshreeJay@users.noreply.github.com> Date: Fri Mar 17 13:11:05 2023 +0530 MyAccount button changes commit d44b593 Author: AshreeJay <52031769+AshreeJay@users.noreply.github.com> Date: Fri Mar 17 12:59:24 2023 +0530 update commit c4e882e Author: AshreeJay <52031769+AshreeJay@users.noreply.github.com> Date: Thu Mar 16 23:01:18 2023 +0530 Update cdp-my-account.component.html commit bdd2fad Author: AshreeJay <52031769+AshreeJay@users.noreply.github.com> Date: Thu Mar 16 22:20:38 2023 +0530 update commit 2d2881b Author: AshreeJay <52031769+AshreeJay@users.noreply.github.com> Date: Thu Mar 16 17:26:21 2023 +0530 update commit f000ec5 Merge: f4fc714 55931c0 Author: Akash Srivastava <akash.srivastava05@sap.com> Date: Thu Mar 16 15:49:16 2023 +0530 Merge branch 'CXINT-1638-bodyContent' of https://github.com/SAP/spartacus into CXINT-1638-bodyContent commit f4fc714 Author: Akash Srivastava <akash.srivastava05@sap.com> Date: Thu Mar 16 15:47:30 2023 +0530 Changes for spinner and images commit 55931c0 Author: AshreeJay <52031769+AshreeJay@users.noreply.github.com> Date: Mon Mar 13 14:19:50 2023 +0530 update commit 87e25db Author: AshreeJay <52031769+AshreeJay@users.noreply.github.com> Date: Sun Mar 12 20:45:04 2023 +0530 update commit 0e3b67b Author: AshreeJay <52031769+AshreeJay@users.noreply.github.com> Date: Fri Mar 10 17:04:19 2023 +0530 update commit 61d46f9 Merge: 76c7f8e 7e981fc Author: Akash Srivastava <akash.srivastava05@sap.com> Date: Fri Mar 10 17:02:22 2023 +0530 Merge branch 'CXINT-1638-bodyContent' of https://github.com/SAP/spartacus into CXINT-1638-bodyContent commit 7e981fc Author: AshreeJay <52031769+AshreeJay@users.noreply.github.com> Date: Fri Mar 10 15:24:06 2023 +0530 update commit 8b030b2 Author: AshreeJay <52031769+AshreeJay@users.noreply.github.com> Date: Fri Mar 10 14:54:27 2023 +0530 myAccount changes commit 76c7f8e Author: Akash Srivastava <akash.srivastava05@sap.com> Date: Fri Mar 10 11:35:48 2023 +0530 Changes for image in order history commit 1e713f9 Author: AshreeJay <52031769+AshreeJay@users.noreply.github.com> Date: Thu Mar 9 18:49:24 2023 +0530 update commit 0b895ce Author: AshreeJay <52031769+AshreeJay@users.noreply.github.com> Date: Thu Mar 9 17:41:34 2023 +0530 resolved conflicts commit a8b930b Author: AshreeJay <52031769+AshreeJay@users.noreply.github.com> Date: Thu Mar 9 17:21:26 2023 +0530 Revert "update" This reverts commit 590432a. commit 590432a Author: AshreeJay <52031769+AshreeJay@users.noreply.github.com> Date: Thu Mar 9 14:34:20 2023 +0530 update commit c04cf58 Merge: 1207570 d03310a Author: AshreeJay <52031769+AshreeJay@users.noreply.github.com> Date: Thu Mar 9 14:13:45 2023 +0530 Merge branch 'CXINT-1634-Order' into CXINT-1638-bodyContent commit 1207570 Author: AshreeJay <52031769+AshreeJay@users.noreply.github.com> Date: Thu Mar 9 14:10:56 2023 +0530 update commit d03310a Author: Akash Srivastava <akash.srivastava05@sap.com> Date: Thu Mar 9 13:32:58 2023 +0530 Changes for css commit cd3d540 Author: AshreeJay <52031769+AshreeJay@users.noreply.github.com> Date: Thu Mar 9 13:15:56 2023 +0530 update commit a30c3f8 Author: Akash Srivastava <akash.srivastava05@sap.com> Date: Wed Mar 8 15:13:45 2023 +0530 CXINT-1807: Doing changes for showing images commit eb3df40 Author: AshreeJay <52031769+AshreeJay@users.noreply.github.com> Date: Wed Mar 8 11:35:37 2023 +0530 update commit 86257ab Author: AshreeJay <52031769+AshreeJay@users.noreply.github.com> Date: Tue Mar 7 10:08:15 2023 +0530 update commit e3f4ced Author: AshreeJay <52031769+AshreeJay@users.noreply.github.com> Date: Mon Mar 6 19:16:52 2023 +0530 update commit 37b1624 Author: AshreeJay <52031769+AshreeJay@users.noreply.github.com> Date: Mon Mar 6 13:23:32 2023 +0530 update commit 75bbf76 Author: Akash Srivastava <akash.srivastava05@sap.com> Date: Mon Mar 6 11:29:40 2023 +0530 CXINT-1634-Order Changes for order histroy page commit f8c88e0 Author: AshreeJay <52031769+AshreeJay@users.noreply.github.com> Date: Tue Feb 14 22:58:09 2023 +0530 update commit e30028c Author: AshreeJay <52031769+AshreeJay@users.noreply.github.com> Date: Tue Feb 14 15:49:33 2023 +0530 update commit 60ec96a Author: AshreeJay <52031769+AshreeJay@users.noreply.github.com> Date: Tue Feb 14 15:18:32 2023 +0530 update commit 104bb15 Author: AshreeJay <52031769+AshreeJay@users.noreply.github.com> Date: Tue Feb 14 13:10:45 2023 +0530 update commit e25f722 Author: AshreeJay <52031769+AshreeJay@users.noreply.github.com> Date: Fri Feb 10 17:53:42 2023 +0530 update commit b3ee1ae Author: AshreeJay <52031769+AshreeJay@users.noreply.github.com> Date: Fri Feb 10 16:20:37 2023 +0530 update commit 1dde8ef Author: AshreeJay <52031769+AshreeJay@users.noreply.github.com> Date: Fri Feb 10 15:36:20 2023 +0530 update commit 11fc1dc Author: AshreeJay <52031769+AshreeJay@users.noreply.github.com> Date: Thu Feb 9 13:59:48 2023 +0530 update commit 5ae8d85 Author: AshreeJay <52031769+AshreeJay@users.noreply.github.com> Date: Wed Feb 8 23:26:57 2023 +0530 added cdp-my-account component commit ec4784e Author: AshreeJay <52031769+AshreeJay@users.noreply.github.com> Date: Wed Feb 8 23:18:23 2023 +0530 removed service commit e30638b Author: AshreeJay <52031769+AshreeJay@users.noreply.github.com> Date: Wed Feb 8 23:05:29 2023 +0530 added cdp-login-component commit 48bbb2c Author: AshreeJay <52031769+AshreeJay@users.noreply.github.com> Date: Wed Feb 8 23:04:33 2023 +0530 update login.component.service.ts commit 64ad2a1 Author: AshreeJay <52031769+AshreeJay@users.noreply.github.com> Date: Wed Feb 8 20:18:54 2023 +0530 created login service commit f871dfe Author: AshreeJay <52031769+AshreeJay@users.noreply.github.com> Date: Tue Feb 7 22:05:57 2023 +0530 update config commit 09af046 Author: AshreeJay <52031769+AshreeJay@users.noreply.github.com> Date: Tue Feb 7 15:20:17 2023 +0530 update configs commit 33f7ead Author: AshreeJay <52031769+AshreeJay@users.noreply.github.com> Date: Tue Feb 7 14:23:08 2023 +0530 generated lib cdp
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous behavior: When
/productsendpoint returned a http error, the code broke in this line, complaining thatthisis undefined.Fix: Preserve the context of
thiswhich was lost in this lineThe problem was revealed only after we implemented CXSPA-2251 where we referenced
thisby addingthis.loggerto the methodProductEffects.productLoadEffectfixes https://jira.tools.sap/browse/CXSPA-3902