fix: (CXSPA-1042) - Empty wishlist notification, heading to paragraph change #18866
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 flaky tests on run #43829 ↗︎
Details:
|
|||||||||||||||||||||||||||||||||||||||||||||
| Test | Artifacts | |
|---|---|---|
| Assisted Service Module > Customer Support Agent - Emulation > should checkout as customer |
Test Replay
Screenshots
Video
|
|
regression/variants/apparel-checkout-flow.core-e2e.cy.ts • 1 flaky test • B2C
| Test | Artifacts | |
|---|---|---|
| Apparel - checkout flow > Mobile > should perform checkout with a registered user |
Test Replay
Screenshots
Video
|
|
regression/variants/apparel-checkout-as-guest.core-e2e.cy.ts • 1 flaky test • B2C
| Test | Artifacts | |
|---|---|---|
| Apparel - checkout as guest > Desktop > should perform checkout as guest, create an account and verify guest data |
Test Replay
Screenshots
Video
|
|
ssr/pages.core-e2e.cy.ts • 3 flaky tests • SSR
| Test | Artifacts | |
|---|---|---|
| SSR > should render homepage |
Test Replay
Screenshots
Video
|
|
| SSR > should render PLP |
Test Replay
Screenshots
Video
|
|
| SSR > should render PDP |
Test Replay
Screenshots
Video
|
|
Review all test suite changes for PR #18866 ↗︎
Zeyber
previously approved these changes
May 20, 2024
| @@ -21,6 +21,10 @@ | |||
| } | |||
| } | |||
|
|
|||
| .cx-empty-wish-list { | |||
| @include type('2', 'normal'); | |||
There was a problem hiding this comment.
type(2) seems quite big in here, let's use the empty default type() instead and aligned center please.
There was a problem hiding this comment.
Done. I've omitted the 'type()' mixin since result would be the same as default paragraph.
developpeurweb
approved these changes
May 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket: CXSPA-1042