Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BREAKING] Remove build execution #740

Merged
merged 25 commits into from Jun 13, 2022
Merged

Conversation

RandomByte
Copy link
Member

@RandomByte RandomByte commented Apr 28, 2022

Build execution is moved to ui5-project (see SAP/ui5-project#457).
Going forward, ui5-builder shall only provide task implementations and selected helper
modules like TaskUtil.

TaskUtil will provide a new getProject() function to custom tasks defining specVersion 2.7 and above.

BREAKING CHANGE:

  • builder.js has been removed. Use ui5-project builder instead
  • Tasks now rely on Project instances being available on Resources (see [BREAKING] Adapt to ui5-project changes. Add Link-reader, WriterCollection ui5-fs#381)
  • TaskRepository#addTask has been removed. Custom tasks need to be added to the project graph instead
  • TaskUtil#get/set/clearTag now requires a Project instance to be provided. Path strings are no longer sufficient
    and will cause an exception to be thrown

@RandomByte RandomByte force-pushed the ui5-project-3.0-enhancements branch from d9678f3 to d72195d Compare May 20, 2022 08:09
@RandomByte RandomByte force-pushed the ui5-project-3.0-enhancements branch from d72195d to 5a6a4e7 Compare May 20, 2022 12:06
Custom tasks shall now be provided as extensions in the ProjectGraph
@RandomByte RandomByte force-pushed the ui5-project-3.0-enhancements branch from 5a6a4e7 to 62a81b9 Compare May 23, 2022 09:12
@RandomByte RandomByte changed the title [INTERNAL] Adopt ui5-project changes [BREAKING] Remove build execution Jun 13, 2022
@RandomByte RandomByte marked this pull request as ready for review June 13, 2022 12:29
@RandomByte RandomByte requested a review from matz3 June 13, 2022 12:45
@RandomByte RandomByte force-pushed the ui5-project-3.0-enhancements branch from cd2764c to 4a9f43d Compare June 13, 2022 15:41
@RandomByte RandomByte merged commit af2e956 into next Jun 13, 2022
@RandomByte RandomByte deleted the ui5-project-3.0-enhancements branch June 13, 2022 18:21
flovogt pushed a commit that referenced this pull request Jun 14, 2022
Build execution is moved to ui5-project (see SAP/ui5-project#457).
Going forward, ui5-builder shall only provide task implementations and selected helper
modules like TaskUtil.

TaskUtil will provide a new `getProject()` function to custom tasks defining specVersion 2.7 and above.

BREAKING CHANGE:
* builder.js has been removed. Use ui5-project builder instead
* Tasks now rely on Project instances being available on Resources (see SAP/ui5-fs#381)
* TaskRepository#addTask has been removed. Custom tasks need to be added to the project graph instead
* TaskUtil#get/set/clearTag now requires a Project instance to be provided. Path strings are no longer sufficient
  and will cause an exception to be thrown

Co-authored-by: Matthias Osswald <mat.osswald@sap.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants