[BREAKING] Adapt to ui5-project changes. Add Link-reader, WriterCollection #381
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove super-collection system from ResourceTagCollection
Link reader:
Allows automatic rewriting of paths and glob patterns to other paths.
I.e. a path "/" can be rewritten to "/resorces/project/namespace"
WriterCollection:
Allows to define a collection of writers mapped to a set of path
prefixes.
I.e. one writer should be used when writing a resource with the path
prefix "/resources/project/namespace/*" and another one for all other
paths ("/")
Resource readers are now created during project graph creation in the corresponding specification implementation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
RandomByte
changed the title
This was referenced Jun 13, 2022
Will create additional tests in follow-up PRs
matz3
approved these changes
Jun 13, 2022
RandomByte
added a commit
to SAP/ui5-builder
that referenced
this pull request
Jun 13, 2022
Build execution is moved to ui5-project (see SAP/ui5-project#457). Going forward, ui5-builder shall only provide task implementations and selected helper modules like TaskUtil. TaskUtil will provide a new `getProject()` function to custom tasks defining specVersion 2.7 and above. BREAKING CHANGE: * builder.js has been removed. Use ui5-project builder instead * Tasks now rely on Project instances being available on Resources (see SAP/ui5-fs#381) * TaskRepository#addTask has been removed. Custom tasks need to be added to the project graph instead * TaskUtil#get/set/clearTag now requires a Project instance to be provided. Path strings are no longer sufficient and will cause an exception to be thrown Co-authored-by: Matthias Osswald <mat.osswald@sap.com>
RandomByte
added a commit
to SAP/ui5-server
that referenced
this pull request
Jun 13, 2022
Adapt to new Project Graph API (see SAP/ui5-project#457) BREAKING CHANGE: * Server now requires a Project Graph instance instead. * Standard middleware now rely on Project instances being available on Resources (see SAP/ui5-fs#381) * MiddlewareRepository#addMiddleware has been removed. Custom middleware need to be added to the project graph instead
flovogt
pushed a commit
to SAP/ui5-builder
that referenced
this pull request
Jun 14, 2022
Build execution is moved to ui5-project (see SAP/ui5-project#457). Going forward, ui5-builder shall only provide task implementations and selected helper modules like TaskUtil. TaskUtil will provide a new `getProject()` function to custom tasks defining specVersion 2.7 and above. BREAKING CHANGE: * builder.js has been removed. Use ui5-project builder instead * Tasks now rely on Project instances being available on Resources (see SAP/ui5-fs#381) * TaskRepository#addTask has been removed. Custom tasks need to be added to the project graph instead * TaskUtil#get/set/clearTag now requires a Project instance to be provided. Path strings are no longer sufficient and will cause an exception to be thrown Co-authored-by: Matthias Osswald <mat.osswald@sap.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Nicer version of #302