-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BREAKING] Remove build execution #740
Merged
Merged
+5,052
−9,730
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RandomByte
force-pushed
the
ui5-project-3.0-enhancements
branch
from
May 20, 2022 08:09
d9678f3
to
d72195d
Compare
…ection To ensure it has access to any resources that might be concealed by a ResourceFacade.
RandomByte
force-pushed
the
ui5-project-3.0-enhancements
branch
from
May 20, 2022 12:06
d72195d
to
5a6a4e7
Compare
Custom tasks shall now be provided as extensions in the ProjectGraph
RandomByte
force-pushed
the
ui5-project-3.0-enhancements
branch
from
May 23, 2022 09:12
5a6a4e7
to
62a81b9
Compare
RandomByte
changed the title
[INTERNAL] Adopt ui5-project changes
[BREAKING] Remove build execution
Jun 13, 2022
Changelog of this version: https://github.com/SAP/ui5-fs/blob/v3.0.0-alpha.4/CHANGELOG.md Use temporary git dependency to @ui5/project
RandomByte
force-pushed
the
ui5-project-3.0-enhancements
branch
from
June 13, 2022 15:41
cd2764c
to
4a9f43d
Compare
matz3
approved these changes
Jun 13, 2022
flovogt
pushed a commit
that referenced
this pull request
Jun 14, 2022
Build execution is moved to ui5-project (see SAP/ui5-project#457). Going forward, ui5-builder shall only provide task implementations and selected helper modules like TaskUtil. TaskUtil will provide a new `getProject()` function to custom tasks defining specVersion 2.7 and above. BREAKING CHANGE: * builder.js has been removed. Use ui5-project builder instead * Tasks now rely on Project instances being available on Resources (see SAP/ui5-fs#381) * TaskRepository#addTask has been removed. Custom tasks need to be added to the project graph instead * TaskUtil#get/set/clearTag now requires a Project instance to be provided. Path strings are no longer sufficient and will cause an exception to be thrown Co-authored-by: Matthias Osswald <mat.osswald@sap.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Build execution is moved to ui5-project (see SAP/ui5-project#457).
Going forward, ui5-builder shall only provide task implementations and selected helper
modules like TaskUtil.
TaskUtil will provide a new
getProject()
function to custom tasks defining specVersion 2.7 and above.BREAKING CHANGE:
and will cause an exception to be thrown