Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[INTERNAL] Document specVersion 2.5 #533

Merged
merged 4 commits into from Jul 23, 2021
Merged

[INTERNAL] Document specVersion 2.5 #533

merged 4 commits into from Jul 23, 2021

Conversation

larskissel
Copy link
Member

Thank you for your contribution! 🙌

To get it merged faster, kindly review the checklist below:

Pull Request Checklist

Copy link
Member

@RandomByte RandomByte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm mostly fine with this change However, the whitespace-trimming changes should be reverted

docs/index.md Show resolved Hide resolved
docs/index.md Outdated Show resolved Hide resolved
docs/pages/Configuration.md Outdated Show resolved Hide resolved
docs/pages/Configuration.md Outdated Show resolved Hide resolved
docs/pages/Configuration.md Outdated Show resolved Hide resolved
docs/pages/Configuration.md Outdated Show resolved Hide resolved
docs/pages/Configuration.md Outdated Show resolved Hide resolved
docs/pages/Configuration.md Outdated Show resolved Hide resolved
- revert mistakenly removal of empty spaces
Copy link
Member

@RandomByte RandomByte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@larskissel larskissel merged commit 020c473 into master Jul 23, 2021
@larskissel larskissel deleted the specVersion-2.5 branch July 23, 2021 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants