[BREAKING] Replace console.log with process.stderr #930
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flovogt
changed the title
This was referenced Feb 23, 2024
RandomByte
requested changes
Feb 28, 2024
Comment on lines
+18
to
+19
| process.stderr.write(hashSum.digest("hex")); | ||
| process.stderr.write("\n"); |
There was a problem hiding this comment.
This breaks the use case of this script:
ui5-tooling/scripts/buildImage.sh
Line 10 in 68f8b72
With this change, DOCKER_TAG will be empty instead of containing the hash.
This should be reverted to console.log
There was a problem hiding this comment.
I don't see a reason to adjust any of those scripts. They're not related to the productive shipment of packages and usage of console.log seems to be totally valid to me.
There was a problem hiding this comment.
True, I was wondering too. There's no need and nobody consumes these scripts outside of this repository. So we could also abandon this PR
d3xter666
added a commit
to SAP/ui5-server
that referenced
this pull request
Feb 29, 2024
BREAKING CHANGE: Messages will now be written to stderr instead of stdout. JIRA: CPOUI5FOUNDATION-802 Related to: SAP/ui5-tooling#701 Sibling of: SAP/ui5-tooling#930, SAP/ui5-cli#686
d3xter666
added a commit
to SAP/ui5-cli
that referenced
this pull request
Feb 29, 2024
BREAKING CHANGE: System messages will now be written to stderr instead of stdout. JIRA: CPOUI5FOUNDATION-802 Related to: SAP/ui5-tooling#701 Sibling of: SAP/ui5-server#643, SAP/ui5-tooling#930
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGE:
Error messages will now be written to stderr instead of stdout.
JIRA: CPOUI5FOUNDATION-802
Related to: #701
Sibling of: SAP/ui5-server#643, SAP/ui5-cli#686