fix(ui5-view-settings-dialog): improve settings management (#7769)

fixes: #7752
SAP · Oct 31, 2023 · 33cdb86 · 33cdb86
1 parent 629e4e6
commit 33cdb86
Showing 1 changed file with 7 additions and 0 deletions.
diff --git a/packages/fiori/src/ViewSettingsDialog.ts b/packages/fiori/src/ViewSettingsDialog.ts
@@ -7,6 +7,7 @@ import type I18nBundle from "@ui5/webcomponents-base/dist/i18nBundle.js";
 import { isPhone } from "@ui5/webcomponents-base/dist/Device.js";
 import litRender from "@ui5/webcomponents-base/dist/renderer/LitRenderer.js";
 import UI5Element from "@ui5/webcomponents-base/dist/UI5Element.js";
+import type { ChangeInfo } from "@ui5/webcomponents-base/dist/UI5Element.js";
 import Dialog from "@ui5/webcomponents/dist/Dialog.js";
 import Button from "@ui5/webcomponents/dist/Button.js";
 import Label from "@ui5/webcomponents/dist/Label.js";
@@ -290,6 +291,12 @@ class ViewSettingsDialog extends UI5Element {
 		}
 	}
 
+	onInvalidation(changeInfo: ChangeInfo) {
+		if (changeInfo.type === "slot") {
+			this._confirmedSettings = this._settings;
+		}
+	}
+
 	_setAdditionalTexts() {
 		// Add the additional text to the filter options
 		this.filterItems.forEach((filter, index) => {