Skip to content

Commit

Permalink
fix(framework): add 72-* font as system styles (#4934)
Browse files Browse the repository at this point in the history
The **72-Bold** font did not apply correctly on stakeholder side in FireFox (see the linked issue for more information.).
This can be also reproduced in our test pages by opening the Card test page **in sap_horizon in FireFox** via this [link](https://sap.github.io/ui5-webcomponents/master/playground/main/pages/Card/?sap-ui-theme=sap_horizon).
The headings in the Card header should have been bold, however they appear normal instead.
The insertion of the **72-Bold,  '72-Boldfull', '72-Light' and  '72-Lightfull'** fonts explicitly as part of the system vars
seem to resolve the issue. The changes is adding the ones that are missing, compared to OpenUi5.

FIXES #4931
  • Loading branch information
ilhan007 committed Mar 22, 2022
1 parent 48b0d6e commit 4b45d32
Show file tree
Hide file tree
Showing 2 changed files with 31 additions and 1 deletion.
2 changes: 1 addition & 1 deletion packages/base/hash.txt
@@ -1 +1 @@
Ymcpo5BI0Vh4B+marW3XQhleQiI=
3A147f62aHRSel1BUKBRiI/tr7o=
30 changes: 30 additions & 0 deletions packages/base/src/css/FontFace.css
Expand Up @@ -35,6 +35,36 @@
url(https://ui5.sap.com/sdk/resources/sap/ui/core/themes/sap_fiori_3/fonts/72-Bold-full.woff?ui5-webcomponents) format("woff");
}

@font-face {
font-family: '72-Bold';
font-style: normal;
src: local('72-Bold'),
url(https://ui5.sap.com/sdk/resources/sap/ui/core/themes/sap_fiori_3/fonts/72-Bold.woff2?ui5-webcomponents) format("woff2"),
url(https://ui5.sap.com/sdk/resources/sap/ui/core/themes/sap_fiori_3/fonts/72-Bold.woff?ui5-webcomponents) format("woff");
}

@font-face {
font-family: '72-Boldfull';
font-style: normal;
src: url(https://ui5.sap.com/sdk/resources/sap/ui/core/themes/sap_fiori_3/fonts/72-Bold-full.woff2?ui5-webcomponents) format("woff2"),
url(https://ui5.sap.com/sdk/resources/sap/ui/core/themes/sap_fiori_3/fonts/72-Bold-full.woff?ui5-webcomponents) format("woff");
}

@font-face {
font-family: '72-Light';
font-style: normal;
src: local('72-Light'),
url(https://ui5.sap.com/sdk/resources/sap/ui/core/themes/sap_fiori_3/fonts/72-Light.woff2?ui5-webcomponents) format("woff2"),
url(https://ui5.sap.com/sdk/resources/sap/ui/core/themes/sap_fiori_3/fonts/72-Light.woff?ui5-webcomponents) format("woff");
}

@font-face {
font-family: '72-Lightfull';
font-style: normal;
src: url(https://ui5.sap.com/sdk/resources/sap/ui/core/themes/sap_fiori_3/fonts/72-Light-full.woff2?ui5-webcomponents) format("woff2"),
url(https://ui5.sap.com/sdk/resources/sap/ui/core/themes/sap_fiori_3/fonts/72-Light-full.woff?ui5-webcomponents) format("woff");
}

@font-face {
font-family: "72Black";
font-style: bold;
Expand Down

0 comments on commit 4b45d32

Please sign in to comment.