Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SF][Urgent][Firefox][1.2.1][Fix expected: within one week] Sap Horizon Theme does not work in Firefox browser #4931

Closed
sfsf-xweb-sh opened this issue Mar 21, 2022 · 1 comment · Fixed by #4934
Closed

[SF][Urgent][Firefox][1.2.1][Fix expected: within one week] Sap Horizon Theme does not work in Firefox browser #4931

sfsf-xweb-sh opened this issue Mar 21, 2022 · 1 comment · Fixed by #4934
Assignees
@ilhan007
Labels
High Prio SAP SF TOPIC Core
Projects
Maintenance - Topic Core

Comments

@sfsf-xweb-sh
Copy link

Dear Colleagues,
I am from Shanghai Web Experience Team

Bug Description
Sap Horizon Theme does not work in Firefox browser

Screen Shot 2022-03-21 at 3 38 28 PM

Expected Behavior
Sap Horizon Theme can work correctly in Firefox browser

I will put the demo link in slack channel due to our company's security policy
@gmkv gmkv self-assigned this Mar 21, 2022
@ilhan007 ilhan007 self-assigned this Mar 21, 2022
@ilhan007 ilhan007 added this to New in Maintenance - Topic Core via automation Mar 21, 2022
@ilhan007 ilhan007 mentioned this issue Mar 21, 2022
Merged
@ilhan007
Copy link
Member

Hello @sfsf-xweb-sh
we have prepared a fix but we want to make sure it works properly on your side before merging, so if you can verify it would be best

Could you just add the following style somewhere in the head of your HTML page and re-check:

@font-face {
    font-family: ‘72-Bold’;
    font-style: normal;
    src: local(‘72-Bold’),
    url(https://ui5.sap.com/sdk/resources/sap/ui/core/themes/sap_fiori_3/fonts/72-Bold.woff2?ui5-webcomponents) format(“woff2”),
    url(https://ui5.sap.com/sdk/resources/sap/ui/core/themes/sap_fiori_3/fonts/72-Bold.woff?ui5-webcomponents) format(“woff”);
}

@ilhan007 ilhan007 moved this from New to In Progress in Maintenance - Topic Core Mar 21, 2022
@gmkv gmkv removed their assignment Mar 21, 2022
Maintenance - Topic Core automation moved this from In Progress to Completed Mar 22, 2022
ilhan007 added a commit that referenced this issue Mar 22, 2022
@ilhan007
fix(framework): add 72-* font as system styles (#4934)
4b45d32 
The **72-Bold** font did not apply correctly on stakeholder side in FireFox (see the linked issue for more information.).
This can be also reproduced in our test pages by opening the Card test page **in sap_horizon in FireFox** via this [link](https://sap.github.io/ui5-webcomponents/master/playground/main/pages/Card/?sap-ui-theme=sap_horizon).
The headings in the Card header should have been bold, however they appear normal instead.
The insertion of the **72-Bold,  '72-Boldfull', '72-Light' and  '72-Lightfull'** fonts explicitly as part of the system vars
seem to resolve the issue. The changes is adding the ones that are missing, compared to OpenUi5.

FIXES #4931
ilhan007 added a commit that referenced this issue Mar 22, 2022
@ilhan007
fix(framework): add 72-* font as system styles (#4934)
8f9b0d2 
The **72-Bold** font did not apply correctly on stakeholder side in FireFox (see the linked issue for more information.).
This can be also reproduced in our test pages by opening the Card test page **in sap_horizon in FireFox** via this [link](https://sap.github.io/ui5-webcomponents/master/playground/main/pages/Card/?sap-ui-theme=sap_horizon).
The headings in the Card header should have been bold, however they appear normal instead.
The insertion of the **72-Bold,  '72-Boldfull', '72-Light' and  '72-Lightfull'** fonts explicitly as part of the system vars
seem to resolve the issue. The changes is adding the ones that are missing, compared to OpenUi5.

FIXES #4931
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ilhan007 ilhan007

Labels
High Prio SAP SF TOPIC Core
Projects
Maintenance - Topic Core
Completed
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(framework): add more 72-* fonts as system styles SAP/ui5-webcomponents
3 participants
@ilhan007 @gmkv @sfsf-xweb-sh