Skip to content

Commit

Permalink
fix(ui5-busy-indicator): add block layer (#9233)
Browse files Browse the repository at this point in the history
According to the design if busy indicator is used over some
component there should be transparent background as overlay.

Fixes: #9079
  • Loading branch information
LidiyaGeorgieva committed Jun 18, 2024
1 parent e53dd2d commit da2c979
Show file tree
Hide file tree
Showing 8 changed files with 19 additions and 2 deletions.
4 changes: 4 additions & 0 deletions packages/main/src/themes/BusyIndicator.css
Original file line number Diff line number Diff line change
Expand Up @@ -89,6 +89,10 @@
flex-direction: column;
}

:host(:not(:empty)) .ui5-busy-indicator-busy-area {
background-color: var(--_ui5_busy_indicator_block_layer);
}

.ui5-busy-indicator-busy-area:focus {
outline: var(--_ui5_busy_indicator_focus_outline);
outline-offset: -2px;
Expand Down
1 change: 1 addition & 0 deletions packages/main/src/themes/base/BusyIndicator-parameters.css
Original file line number Diff line number Diff line change
Expand Up @@ -2,4 +2,5 @@
--_ui5_busy_indicator_color: var(--sapContent_IconColor);
--_ui5_busy_indicator_focus_outline: var(--sapContent_FocusWidth) var(--sapContent_FocusStyle) var(--sapContent_FocusColor);
--_ui5_busy_indicator_focus_border_radius: 0px;
--_ui5_busy_indicator_block_layer: color-mix(in oklch, transparent, var(--sapBlockLayer_Background) 20%);
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
@import "../base/BusyIndicator-parameters.css";

:root {
--_ui5_busy_indicator_block_layer: color-mix(in oklch, transparent, var(--sapBlockLayer_Background) 30%);
}
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
@import "../base/AvatarGroup-parameters.css";
@import "./Badge-parameters.css";
@import "../base/BrowserScrollbar-parameters.css";
@import "../base/BusyIndicator-parameters.css";
@import "./BusyIndicator-parameters.css";
@import "./Button-parameters.css";
@import "../base/CalendarLegend-parameters.css";
@import "../base/CalendarLegendItem-parameters.css";
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
@import "../base/BusyIndicator-parameters.css";

:root {
--_ui5_busy_indicator_block_layer: color-mix(in oklch, transparent, var(--sapBlockLayer_Background) 30%);
}
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
@import "../base/AvatarGroup-parameters.css";
@import "./Badge-parameters.css";
@import "../base/BrowserScrollbar-parameters.css";
@import "../base/BusyIndicator-parameters.css";
@import "./BusyIndicator-parameters.css";
@import "./Button-parameters.css";
@import "../base/CalendarLegend-parameters.css";
@import "../base/CalendarLegendItem-parameters.css";
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -2,4 +2,5 @@

:root {
--_ui5_busy_indicator_color: var(--sapContent_BusyColor);
--_ui5_busy_indicator_block_layer: color-mix(in oklch, transparent, var(--sapBlockLayer_Background) 30%);
}
Original file line number Diff line number Diff line change
Expand Up @@ -2,4 +2,5 @@

:root {
--_ui5_busy_indicator_color: var(--sapContent_BusyColor);
--_ui5_busy_indicator_block_layer: color-mix(in oklch, transparent, var(--sapBlockLayer_Background) 30%);
}

0 comments on commit da2c979

Please sign in to comment.