Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BusyIndicator]: dimmed overlay is missing #9079

Closed
1 task done
ilhan007 opened this issue May 29, 2024 · 0 comments · Fixed by #9208
Closed
1 task done

[BusyIndicator]: dimmed overlay is missing #9079

ilhan007 opened this issue May 29, 2024 · 0 comments · Fixed by #9208
Assignees
Labels
Milestone

Comments

@ilhan007
Copy link
Member

Bug Description

When the BusyIndicator is active, animated dots are present, and the component wraps the content that is meant to be busy, the dimmed layer is missing, which is one of the key visualisation of the busy state

Affected Component

ui5-busy-indicator

Expected Behaviour

No response

Isolated Example

No response

Steps to Reproduce

  1. Open https://sap.github.io/ui5-webcomponents/nightly/packages/main/test/pages/BusyIndicator.html
  2. Observe the missing dimmed layer

...

Log Output, Stack Trace or Screenshots

No response

Priority

None

UI5 Web Components Version

latest

Browser

Chrome

Operating System

No response

Additional Context

No response

Organization

No response

Declaration

  • I’m not disclosing any internal or sensitive information.
@ilhan007 ilhan007 added bug This issue is a bug in the code TOPIC RD labels May 29, 2024
@ilhan007 ilhan007 added this to New Issues in Maintenance - Topic RD via automation May 29, 2024
@TeodorTaushanov TeodorTaushanov removed their assignment May 29, 2024
@LidiyaGeorgieva LidiyaGeorgieva self-assigned this Jun 13, 2024
LidiyaGeorgieva added a commit that referenced this issue Jun 13, 2024
According to the design if busy indicator is used over some component there shoul be
transparent background as overlay.

fixes #9079
Maintenance - Topic RD automation moved this from New Issues to Completed Jun 14, 2024
ilhan007 pushed a commit that referenced this issue Jun 14, 2024
* fix(ui5-busy-indicator): add block layer

According to the design if busy indicator is used over some component there should be
transparent background as overlay.

fixes #9079
kgogov pushed a commit that referenced this issue Jun 17, 2024
* fix(ui5-busy-indicator): add block layer

According to the design if busy indicator is used over some component there should be
transparent background as overlay.

fixes #9079
LidiyaGeorgieva added a commit that referenced this issue Jun 17, 2024
According to the design if busy indicator is used over some
component there should be transparent background as overlay.

fixes #9079
LidiyaGeorgieva added a commit that referenced this issue Jun 17, 2024
According to the design if busy indicator is used over some
component there should be transparent background as overlay.

fixes #9079
ilhan007 pushed a commit that referenced this issue Jun 18, 2024
According to the design if busy indicator is used over some
component there should be transparent background as overlay.

Fixes: #9079
@ilhan007 ilhan007 added this to the 1.24.5 milestone Jun 18, 2024
LidiyaGeorgieva added a commit that referenced this issue Jun 19, 2024
According to the design if busy indicator is used over some component there shoul be
transparenr background as overlay.

fixes #9079
LidiyaGeorgieva added a commit that referenced this issue Jun 20, 2024
According to the design if busy indicator is used over some component there shoul be
transparenr background as overlay.

fixes #9079
LidiyaGeorgieva added a commit that referenced this issue Jun 20, 2024
* fix(ui5-busy-indicator): add block layer

According to the design if busy indicator is used over some component there shoul be
transparenr background as overlay.

fixes #9079

* fix(ui5-tab-container): enhance documentation page and change display

When display was "inline-block" there was a small gap on the top of the TabContainer.
Now dispaly is changed to "block" and this gap is gone.
The documentation page with the samples now have descriptions added,
the samples are bigger in height and every sample contains only one TabContainer.

fixes: #9248
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Completed
3 participants