Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ui5-badge - colors are incorrect #2210

Closed
vladitasev opened this issue Sep 11, 2020 · 0 comments · Fixed by #2216
Closed

ui5-badge - colors are incorrect #2210

vladitasev opened this issue Sep 11, 2020 · 0 comments · Fixed by #2216
Assignees
@nnaydenow
Labels
Medium Prio
Projects
Planning - Topic Core
Milestone
1.0.0-rc.9

Comments

@vladitasev
Copy link
Contributor

fori 3 colors are a little off - the green is not the intended one (potentially others as well) - investigate
HC* themes: no colors should be present except for white and black.
@ilhan007 ilhan007 added this to the 1.0.0-rc.9 milestone Sep 14, 2020
@ilhan007 ilhan007 added this to 1.0.0-rc.9 (start of Oct, 2020) in UI5 Web Components - Roadmap Sep 14, 2020
@ilhan007 ilhan007 added this to Core Team in Planning - Topic Core Sep 14, 2020
@nnaydenow nnaydenow mentioned this issue Sep 14, 2020
Merged
ilhan007 pushed a commit that referenced this issue Sep 16, 2020
@nnaydenow
fix(ui5-badge): update colors to match the spec(#2216)
2ddc4e9 
Aligned colors to Quartz Light and Dark and High Contrast themes.

Fixes: #2210
Todor-ads pushed a commit to Todor-ads/ui5-webcomponents that referenced this issue Sep 17, 2020
@nnaydenow @Todor-ads
fix(ui5-badge): update colors to match the spec(SAP#2216)
560ca75 
Aligned colors to Quartz Light and Dark and High Contrast themes.

Fixes: SAP#2210
ilhan007 pushed a commit that referenced this issue Oct 17, 2020
@nnaydenow @ilhan007
fix(ui5-badge): update colors to match the spec(#2216)
1c78747 
Aligned colors to Quartz Light and Dark and High Contrast themes.

Fixes: #2210
ilhan007 pushed a commit that referenced this issue Nov 11, 2020
@nnaydenow @ilhan007
fix(ui5-badge): update colors to match the spec(#2216)
643a62b 
Aligned colors to Quartz Light and Dark and High Contrast themes.

Fixes: #2210
@ilhan007 ilhan007 moved this from Core to Completed in Planning - Topic Core Nov 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nnaydenow nnaydenow

Labels
Medium Prio
Projects
Planning - Topic Core
Status: Completed
Planning - Topic Core
  
Completed
Milestone
1.0.0-rc.9
Development

Successfully merging a pull request may close this issue.

fix(ui5-badge): colors alignment
3 participants
@ilhan007 @vladitasev @nnaydenow