Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ui5-badge): colors alignment #2216

Merged
merged 1 commit into from
Sep 16, 2020
Merged

fix(ui5-badge): colors alignment #2216

merged 1 commit into from
Sep 16, 2020

Conversation

nnaydenow
Copy link
Contributor

Aligned colors to Quatz light / dark and high contrast themes.

Fixes: #2210

@nnaydenow nnaydenow requested review from ilhan007 and vladitasev and removed request for ilhan007 September 14, 2020 11:46
ilhan007
ilhan007 reviewed Sep 14, 2020
View reviewed changes
Copy link
Member

@ilhan007 ilhan007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change is fine, let's wait for Jens Henninger to check if the spec is correct
as it is a little odd that for schema 5 we have to use --sapLegendBackgroundColor20, instead of sapLegendBackgroundColor5 and other similar contradictions.

@ilhan007 ilhan007 merged commit 2ddc4e9 into SAP:master Sep 16, 2020
Todor-ads pushed a commit to Todor-ads/ui5-webcomponents that referenced this pull request Sep 17, 2020
@nnaydenow @Todor-ads
fix(ui5-badge): update colors to match the spec(SAP#2216)
560ca75 
Aligned colors to Quartz Light and Dark and High Contrast themes.

Fixes: SAP#2210
ilhan007 pushed a commit that referenced this pull request Oct 17, 2020
@nnaydenow @ilhan007
fix(ui5-badge): update colors to match the spec(#2216)
1c78747 
Aligned colors to Quartz Light and Dark and High Contrast themes.

Fixes: #2210
ilhan007 pushed a commit that referenced this pull request Nov 11, 2020
@nnaydenow @ilhan007
fix(ui5-badge): update colors to match the spec(#2216)
643a62b 
Aligned colors to Quartz Light and Dark and High Contrast themes.

Fixes: #2210
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ilhan007 ilhan007 ilhan007 approved these changes

@vladitasev vladitasev Awaiting requested review from vladitasev

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ui5-badge - colors are incorrect
2 participants
@nnaydenow @ilhan007