Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ui5-link does not support aria-label #2356

Closed
ee92 opened this issue Oct 14, 2020 · 0 comments · Fixed by #2357
Closed

ui5-link does not support aria-label #2356

ee92 opened this issue Oct 14, 2020 · 0 comments · Fixed by #2357
Assignees
@ilhan007
Labels
ACC SAP SF SF_ACC TOPIC Core
Milestone
0.23.6

Comments

@ee92
Copy link

ee92 commented Oct 14, 2020

Describe the bug
The ui5-link component does not pass any aria attributes down to the anchor tag inside it, so screenreaders only read the inner text of the link.

To reproduce
Steps to reproduce the behavior:

  1. Go to https://sap.github.io/ui5-webcomponents/playground/components/Link/ in chrome
  2. using dev tools, add an aria-label to a ui5-link
  3. notice the anchor tag in the shadow root does not get the aria-label
  4. using any screenreader, focus on the link and notice the aria-label is not read out.

Expected behavior
The aria-label and aria-labelledby attributes should be respected by ui5-link and passed to the inner anchor element to allow compliance with accessibility standards.

Screenshots
Screen Shot 2020-10-14 at 8 40 37 AM

Context

  • UI5 Web Components version: any
  • screen reader: NVDA, JAWS, Mac VoiceOver

Affected components
ui5-link

Organization:
SuccessFactors

Priority:
Medium

Thank you!
@ilhan007 ilhan007 self-assigned this Oct 14, 2020
@ilhan007 ilhan007 mentioned this issue Oct 14, 2020
Merged
ilhan007 added a commit that referenced this issue Oct 23, 2020
@ilhan007
feat(ui5-link): add aria-label and aria-labelledby support (#2357)
7e65e77 
FIXES: #2356
ilhan007 added a commit that referenced this issue Nov 2, 2020
@ilhan007
feat(ui5-link): add aria-label and aria-labelledby support (#2357)
178af99 
FIXES: #2356
@ilhan007 ilhan007 added this to the 0.23.6 milestone Nov 2, 2020
@ilhan007 ilhan007 added this to 0.23.6 (27 Oct) in UI5 Web Components - Roadmap Nov 2, 2020
ilhan007 added a commit that referenced this issue Nov 11, 2020
@ilhan007
feat(ui5-link): add aria-label and aria-labelledby support (#2357)
6a50732 
FIXES: #2356
ilhan007 added a commit that referenced this issue Nov 19, 2020
@ilhan007
feat(ui5-link): add aria-label and aria-labelledby support (#2357)
6b421b7 
FIXES: #2356
@fifoosid fifoosid mentioned this issue Jun 21, 2021
Merged
ilhan007 pushed a commit that referenced this issue Jul 30, 2021
@fifoosid
feat: implement assessibleNameRef for many components (#3442)
42d3ed5 
Part of #3107 

BREAKING CHANGE: The support for ```aria-labelledby``` have been deprecated in favour of  new attribute ```accessible-name-ref``` for the following components:
- ComboBox (Requested by SF #1916)
- DatePicker (Requested by SF #2107)
- Input (Requested #1866)
- List (Requested by SF #1886)
- Rating Indicator
- Select (Requested by SF #2107)
- StepInput (Implemented as part of the initial implementation #2804)
- TextArea (Requested by SF #2107)
- WizardStep (Implemented as part of the initial implementation #2400)
The ```aria-labelledby``` has been deprecated for the following component:
- Button (Requested by SF #1425)
The ```accessible-name``` has been deprecated for the following components:
- Link (Requested by SF #2356)
 Both ```aria-labelledby``` and ```accessible-name``` have been deprecated for the following components:
- Card (Requested by CBC #2127)
- CheckBox (Requested by SF #2265)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ilhan007 ilhan007

Labels
ACC SAP SF SF_ACC TOPIC Core
Projects
None yet
Milestone
0.23.6
Development

Successfully merging a pull request may close this issue.

feat(ui5-link): add aria-label and aria-labelledby support SAP/ui5-webcomponents
3 participants
@ilhan007 @nikolay-kolarov @ee92