Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: implement assessibleNameRef for many components #3442

Merged
merged 15 commits into from
Jul 30, 2021

Conversation

fifoosid
Copy link
Contributor

@fifoosid fifoosid commented Jun 17, 2021

Part of #3107

BREAKING CHANGE:
‼️ aria-labelledby is deprecated in favour of accessible-name-ref for the following components:

‼️ aria-labelledby is deprecated for the following components:

‼️ accessible-name is deprecated for the following components:

‼️ Both aria-labelledby and accessible-name are deprecated for the following components:

elenastoyanovaa
elenastoyanovaa previously approved these changes Jul 9, 2021
ilhan007
ilhan007 previously approved these changes Jul 15, 2021
@fifoosid fifoosid dismissed stale reviews from ilhan007 and elenastoyanovaa via a02fb74 July 15, 2021 12:16
Copy link
Member

@ilhan007 ilhan007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's just hold it for now to discuss with the ACC experts if we should keep the accesisibleNameRef for non-form components: WizardStep, Card, CheckBox, Link, List, Button and do we have better alternative.

@ilhan007
Copy link
Member

Adopt the following change: #3490
and remove the ariaLabel and ariaLabelledby API (or whatever you agreed with the ACC experts) in both Card.js CardHeader.js

@ilhan007
Copy link
Member

there are new conflicts after recent merges...

@ilhan007
Copy link
Member

Hi @elenastoyanovaa could you make a final review this change

ilhan007
ilhan007 previously approved these changes Jul 30, 2021
@ilhan007 ilhan007 merged commit 42d3ed5 into master Jul 30, 2021
@ilhan007 ilhan007 deleted the accessiblenameref branch July 30, 2021 08:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants