Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SF][A11Y][Badge]: Fails to meet color contrast ratio with respect to background color when color scheme is "1" #3940

Closed
1 task
sfsf-xweb-sh opened this issue Sep 16, 2021 · 7 comments
Assignees

Comments

@sfsf-xweb-sh
Copy link

Hi Colleague,
There is a A11Y issue:Fails to meet color contrast ratio with respect to background color when color scheme is "8".
Please take a look. This issue affect OMP and Assignment(b2111 release).

Screen Shot 2021-09-16 at 5 40 08 PM

Expected Behavior

Screen Shot 2021-09-16 at 5 44 31 PM

Context

  • UI5 Web Components version: {0.31.17}
  • Browser: {chrome}

Priority

  • High
@ilhan007
Copy link
Member

Hello @SAP/ui5-webcomponents-topic-rd could you check the contrast ration issue that has been reported. Perhaps this might be fixed with the latest color changes.

#3926

@ilhan007
Copy link
Member

Hello @sfsf-xweb-sh the title mentions scheme "1", the issue description - scheme "8". Is it 1 or 8 at the end.

@georgimkv georgimkv self-assigned this Sep 17, 2021
@georgimkv
Copy link
Contributor

The one pictured is color-scheme="1". And it indeed fails to meet the minimum contrast ratio. I'll discuss this with the design team.

@georgimkv
Copy link
Contributor

Hi @sfsf-xweb-sh
The design team advised that when the text inside the Badge is bold, it is acceptable to have lower contrast ratio.
This is described here https://wiki.wdf.sap.corp/wiki/pages/viewpage.action?pageId=2095479022#Accessibility(Fiori3)-ACC-261-MinimumContrast

Regards,
Georgi

@sfsf-xweb-sh
Copy link
Author

Hello @sfsf-xweb-sh the title mentions scheme "1", the issue description - scheme "8". Is it 1 or 8 at the end.

Sorry for typo error, It's 1 in this issue.

@sfsf-xweb-sh
Copy link
Author

sfsf-xweb-sh commented Jan 28, 2022

Hi @gmkv @ilhan007 ,
There are some update about this issue.
@anu Sandhanam(I524170) said that this is a valid issue, not all bold text can meet a color contrast lesser than 4.5:1. Only text that is 14 pt bold or 18 pt normal is categorized as large text in which case its enough if they meet 3:1 CC. In this case, the status text is 14 px (not 14 pt).
image
Could you help reopen it. And double check it with @anu Sandhanam(I524170) if it's necessary.

Best Regards,
Josephine su

@georgimkv georgimkv reopened this Jan 28, 2022
@georgimkv georgimkv added bug This issue is a bug in the code and removed consulting labels Feb 1, 2022
georgimkv added a commit that referenced this issue Feb 1, 2022
The text color of the badge was update to the latest Fiori 3
specification.

 #3940
georgimkv added a commit that referenced this issue Feb 1, 2022
The text color of the badge was update to the latest Fiori 3
specification.

 #3940
georgimkv added a commit that referenced this issue Feb 2, 2022
The text color of the badge was update to the latest Fiori 3
specification.

 #3940
@georgimkv
Copy link
Contributor

Hi @sfsf-xweb-sh

The component's colors were updated. The fix will be available with the next release of ui5-webcomponents.

@ilhan007 ilhan007 closed this as completed Feb 2, 2022
ilhan007 pushed a commit that referenced this issue Feb 3, 2022
The text color of the badge was update to the latest Fiori 3
specification.

 #3940
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Completed
Development

No branches or pull requests

4 participants