Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ui5-tabcontainer show overflow popover does not work with namespaced ui5-button #4261

Closed
1 of 4 tasks
JarrettChan opened this issue Nov 3, 2021 · 1 comment · Fixed by #4273
Closed
1 of 4 tasks
Labels
bug This issue is a bug in the code High Prio SAP SF TOPIC RD

Comments

@JarrettChan
Copy link

Bug Description

If the ui5-button is namespaced with a suffix, clicking the ui5-button to show the overflow popover does not do anything.

Expected Behavior

ui5-tabcontainer overflow should select ui5-button with a stable selector:
const button = this.overflowButton[0] || this.getDomRef().querySelector(".ui-tc__overflowButton > ui5-button");
please use the pure tag or some equivalent to select the ui5-button

Isolated Example

https://codesandbox.io/s/ui5-webcomponents-forked-30gex

Priority

  • Low
  • Medium
  • High
  • Very High

Note: The priority might be re-evaluated by the issue processor.

Stakeholder Info (if applicable)

  • Organization: SuccessFactors
  • Business impact: blocking adoption of namespaced elements
@JarrettChan
Copy link
Author

Attempting to use addCustomCSS across multiple ui5wc cores does not work currently.
To fix from our side would need to either namespace the elements to be able to use addCustomCSS (blocked by this issue) or the other option I'm exploring is manually traversing and inserting a style tag.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This issue is a bug in the code High Prio SAP SF TOPIC RD
Projects
Status: Completed
Development

Successfully merging a pull request may close this issue.

2 participants