Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The ui5-select component dropdown list doesn't have the right rows height according to the Fiori visual specification #4616

Closed
1 of 4 tasks
unazko opened this issue Jan 24, 2022 · 1 comment · Fixed by #4650
Assignees
Labels
bug This issue is a bug in the code Medium Prio TOPIC P

Comments

@unazko
Copy link
Contributor

unazko commented Jan 24, 2022

Bug Description

Drop down rows height of the ui5-select component doesn't comply with specified in the visual specification.
There are differences in Cozy and Compact form-factor modes.

Expected Behavior

The rows height should comply with the specified in the visual specification.

Steps to Reproduce

  1. Go to https://sap.github.io/ui5-webcomponents/playground/components/Select/
  2. Open the "Basic Select" select drop down list
  3. Inspect the list row height

Isolated Example

If possible, please provide an isolated example by forking CodeSandbox.

Context

  • UI5 Web Components version: {lastest}
  • OS/Platform: {Windows 10}
  • Browser: {Chrome}
  • Affected component: {ui5-select}

Log Output / Stack Trace / Screenshots

spec_row_heigh
select_cozy_row

Priority

  • Low
  • Medium
  • High
  • Very High
@unazko unazko added bug This issue is a bug in the code Medium Prio TOPIC P labels Jan 24, 2022
@unazko
Copy link
Contributor Author

unazko commented Jan 24, 2022

Hello @ui5-webcomponents-topic-p,

Could you take over this issue as it is related to the ui5-select component.

Best Regards,
Boyan

@dobrinyonkov dobrinyonkov self-assigned this Jan 27, 2022
dobrinyonkov added a commit to dobrinyonkov/ui5-webcomponents that referenced this issue Jan 27, 2022
List items of suggestion popovers are now aligned with FIori visual specification and have correct height of 2.5rem for Cozy and 2rem for Compact.

Fixes: SAP#4616
dobrinyonkov added a commit that referenced this issue Jan 28, 2022
List items of suggestion popovers are now aligned with FIori visual specification and have correct height of 2.5rem for Cozy and 2rem for Compact.

Fixes: #4616
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This issue is a bug in the code Medium Prio TOPIC P
Projects
Status: Completed
Development

Successfully merging a pull request may close this issue.

2 participants