Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Icon: default value for design is wrong. #8375

Closed
1 task done
Lukas742 opened this issue Mar 1, 2024 · 1 comment · Fixed by #8376
Closed
1 task done

Icon: default value for design is wrong. #8375

Lukas742 opened this issue Mar 1, 2024 · 1 comment · Fixed by #8376
Assignees
@plamenivanov91
Labels
bug This issue is a bug in the code TOPIC P
Projects
Maintenance - Topic P

Comments

@Lukas742
Copy link
Collaborator

Lukas742 commented Mar 1, 2024

Bug Description

The default value of the design property/attribute is wrong. It is outlined as "Default" but really is using the "NonInteractive" design.

Affected Component

ui5-icon

Expected Behaviour

No response

Isolated Example

https://stackblitz.com/edit/js-4yvzdo?file=index.js,index.html

Steps to Reproduce

  1. Go to stackblitz
  2. See that the designs of the icons differ

Log Output, Stack Trace or Screenshots

No response

Priority

None

UI5 Web Components Version

1.22.0

Browser

Chrome

Operating System

No response

Additional Context

No response

Organization

MXP & UI5WCR

Declaration

  • I’m not disclosing any internal or sensitive information.
@Lukas742 Lukas742 added the bug This issue is a bug in the code label Mar 1, 2024
@nnaydenow nnaydenow added this to Issues in Maintenance - Topic P via automation Mar 1, 2024
@nnaydenow
Copy link
Contributor

Hi @SAP/ui5-webcomponents-topic-p,

Please take a look over this issue.

@plamenivanov91 plamenivanov91 self-assigned this Mar 1, 2024
@plamenivanov91 plamenivanov91 moved this from Issues to In Progress in Maintenance - Topic P Mar 1, 2024
plamenivanov91 added a commit to plamenivanov91/ui5-webcomponents that referenced this issue Mar 1, 2024
@plamenivanov91
fix(ui5-icon): default icon color aligned with specification
cac3685 
Fixes: SAP#8375
@plamenivanov91 plamenivanov91 mentioned this issue Mar 1, 2024
Merged
plamenivanov91 added a commit that referenced this issue Mar 7, 2024
@plamenivanov91
fix(ui5-icon): default icon color aligned with specification (#8376)
7915a8c 
Fixes: #8375
Maintenance - Topic P automation moved this from In Progress to Completed Mar 7, 2024
nnaydenow pushed a commit that referenced this issue Mar 20, 2024
@plamenivanov91
fix(ui5-icon): default icon color aligned with specification (#8376)
278ca2a 
Fixes: #8375
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@plamenivanov91 plamenivanov91

Labels
bug This issue is a bug in the code TOPIC P
Projects
Maintenance - Topic P
Status: Completed
Maintenance - Topic P
  
Completed
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(ui5-icon): default icon color aligned with specification plamenivanov91/ui5-webcomponents
3 participants
@Lukas742 @plamenivanov91 @nnaydenow