Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ui5-button): make aria-label work for ui5-button #1445

Merged
merged 10 commits into from
Apr 24, 2020
Merged

fix(ui5-button): make aria-label work for ui5-button #1445

merged 10 commits into from
Apr 24, 2020

Conversation

fifoosid
Copy link
Contributor

@fifoosid fifoosid commented Apr 8, 2020

No description provided.

@fifoosid fifoosid changed the title Button aria label POC: Button aria label Apr 8, 2020
@fifoosid fifoosid mentioned this pull request Apr 10, 2020
Closed
vladitasev
vladitasev requested changes Apr 13, 2020
View reviewed changes
Copy link
Contributor

@vladitasev vladitasev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just change the title and we can merge

@vladitasev vladitasev changed the title POC: Button aria label fix(ui5-button): make aria-label work for ui5-button Apr 13, 2020
vladitasev
vladitasev previously approved these changes Apr 13, 2020
View reviewed changes
@fifoosid fifoosid merged commit f0f8964 into master Apr 24, 2020
@fifoosid fifoosid deleted the button-aria-label branch April 24, 2020 07:20
@fifoosid
Copy link
Contributor Author

Fixes #1425

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vladitasev vladitasev vladitasev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fifoosid @vladitasev