fix: disable click events for disabled ui5-button #586
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add pointer-events: none to host component so in case it is disabled, the browser does not call click handlers registered to it. add chai for better assertion messages
ilhan007
previously approved these changes
Jun 25, 2019
this way, the component can handle the click first and then the app handler will have the correct component state in its click handler
With click handlers registered in the shadow dom, the qunit tests can no longer simulate events correctly. For these scenarios, the wdio tests will be used anyway.
- remove disabled check, CSS takes care of that
vladitasev
approved these changes
Jun 26, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add pointer-events: none to host component so in case it is disabled,
the browser does not call click handlers registered to it.
add chai for better assertion messages
switch click handler to shadow dom so it runs before the application click handler
add tests for click for ui5-button and ui5-togglebutton
Fixes: #572