Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: disable click events for disabled ui5-button #586

Merged
merged 6 commits into from
Jun 26, 2019

Commits on Jun 25, 2019

  1. fix: disable click events for disabled ui5-button

    add pointer-events: none to host component so in case it is disabled,
    the browser does not call click handlers registered to it.
    
    add chai for better assertion messages
    pskelin committed Jun 25, 2019
    Configuration menu
    Copy the full SHA
    58b0821 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    a5bdaec View commit details
    Browse the repository at this point in the history

Commits on Jun 26, 2019

  1. move click handler to shadow dom

    this way, the component can handle the click first and then the app handler
    will have the correct component state in its click handler
    pskelin committed Jun 26, 2019
    Configuration menu
    Copy the full SHA
    0a939be View commit details
    Browse the repository at this point in the history
  2. remove event-related qunit tests

    With click handlers registered in the shadow dom, the qunit tests
    can no longer simulate events correctly.
    For these scenarios, the wdio tests will be used anyway.
    pskelin committed Jun 26, 2019
    Configuration menu
    Copy the full SHA
    fa0e6a3 View commit details
    Browse the repository at this point in the history
  3. fix ie11 mousedown problem in IE11

    - remove disabled check, CSS takes care of that
    pskelin committed Jun 26, 2019
    Configuration menu
    Copy the full SHA
    0a8ba65 View commit details
    Browse the repository at this point in the history
  4. fix test page

    pskelin committed Jun 26, 2019
    Configuration menu
    Copy the full SHA
    07e3057 View commit details
    Browse the repository at this point in the history