feat(ui5-side-navigation): add external link icon #8199
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
if the navigation item is an external link, show the external link indicator
There was a problem hiding this comment.
expand/collapse arrows are missing in this sample:
https://sap.github.io/ui5-webcomponents/nightly/playground/fiori/pages/SideNavigationOnly/?sap-ui-theme=sap_horizon#events
Address comments from code review. Expand icon is no longer missing
There was a problem hiding this comment.
Please add more samples:
- in the Story books
- in the fixed part of the Side Navigation
- maybe example with disabled item
Please add tests.
Please check again if the color of the arrow is correct:
https://wiki.one.int.sap/wiki/display/CPDesign/Vertical+Navigation
https://wiki.one.int.sap/wiki/pages/viewpage.action?pageId=2650676561
currently is "#1d2d3e;" for Horizon
Address review comments
TeodorTaushanov
requested changes
Feb 6, 2024
packages/fiori/src/themes/sap_horizon_hcb/SideNavigation-parameters.css
Outdated
Show resolved
Hide resolved
changed samples
TeodorTaushanov
approved these changes
Feb 13, 2024
tsanislavgatev
pushed a commit
that referenced
this pull request
Feb 20, 2024
* feat(ui5-side-navigation): add external link icon if the navigation item is an external link, show the external link indicator * feat(ui5-side-navigation): add external link icon Address comments from code review. Expand icon is no longer missing * feat(ui5-side-navigation): add external link icon Address review comments * feat(ui5-side-navigation): add external link icon changed samples
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
if the navigation item is an external link, show the external link indicator