Use constructor arguments instead of properties in more places #247
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stig
force-pushed
the
more-constructor-args
branch
from
68a05f6
to
ebd36f9
Compare
stig
changed the title
Settable properties implies that we can change writer properties during writing, which is not a great idea. So set properties only in the constructor.
stig
force-pushed
the
more-constructor-args
branch
from
ebd36f9
to
20d2700
Compare
Current coverage is 90.41% (diff: 95.12%)@@ master #247 diff @@
==========================================
Files 17 17
Lines 1023 1033 +10
Methods 233 231 -2
Messages 0 0
Branches 106 106
==========================================
+ Hits 926 934 +8
- Misses 58 60 +2
Partials 39 39
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move away from properties for the Writer
Settable properties implies that we can change writer properties during
writing, which is not a great idea. So set properties only in the constructor.
Change stream writer to take read-only properties in constructor
Use constructor arguments rather than properties in stream parser