Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deactivated TrackTimeInterval test #79

Merged
merged 1 commit into from
Feb 1, 2024
Merged

Deactivated TrackTimeInterval test #79

merged 1 commit into from
Feb 1, 2024

Conversation

PetrilloAtWork
Copy link
Member

A long-failing test is being deactivated.

See issue SBNSoftware/icaruscode#666.

mmrosenberg
mmrosenberg approved these changes Feb 1, 2024
View reviewed changes
Copy link
Contributor

@mmrosenberg mmrosenberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good to me. I don't remember the cause of the failure but I do recall that it was introduced by a LArSoft update some time ago, investigated, and determined not to be a cause for concern

@mmrosenberg mmrosenberg mentioned this pull request Feb 1, 2024
Merged
@mmrosenberg mmrosenberg merged commit f174751 into develop Feb 1, 2024
@mmrosenberg mmrosenberg deleted the feature/gp_issue666 branch February 1, 2024 22:37
@SFBayLaser SFBayLaser added the maintenance Technical changes and removal/updated of obsolete code label Feb 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mmrosenberg mmrosenberg mmrosenberg approved these changes

@SFBayLaser SFBayLaser Awaiting requested review from SFBayLaser

Assignees

@PetrilloAtWork PetrilloAtWork

Labels
maintenance Technical changes and removal/updated of obsolete code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@PetrilloAtWork @mmrosenberg @SFBayLaser