-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sbnd/icaruscode data objects should move to sbnobj #9
Comments
We need to identify which are the data products to be shared. I suppose that the first step is to move only the first ones. @tgrbrooks and @chilge should confirm they are equivalent... |
Issue #10 created to track the creation of |
OK, #2 complete I think, allowing this to proceed. |
I think our |
OK, I'm starting to work on some of this migrating of data products now ... |
Initial branch at SBNSoftware/sbnobj#2 Have added in ICARUS PMT Trigger data objects, and CRT data objects across the board. For the CRT ones, I've made 'common' ones for CRTHit, CRTTrack, and CRTTzero, though I've also copied the existing versions in each namespace because I worried about backwards compatibility (those are in the _Legacy.hh file). We should consider if we need that/when we can drop it. I've just allowed experiement-specific CRTData objects (with only namespaces differing to distinguish the names). We should also consider if we can merge those or what. |
This has been moved to the testing phase (#13). |
Initial implementation done. Closing. |
No description provided.
The text was updated successfully, but these errors were encountered: