Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sbnd/icaruscode data objects should move to sbnobj #9

Closed
cjbacchus opened this issue Jun 15, 2020 · 8 comments
Closed

sbnd/icaruscode data objects should move to sbnobj #9

cjbacchus opened this issue Jun 15, 2020 · 8 comments
Assignees

Comments

@cjbacchus
Copy link
Contributor

No description provided.

@PetrilloAtWork
Copy link
Member

PetrilloAtWork commented Jun 15, 2020

We need to identify which are the data products to be shared.
Currently icaruscode has CRT data products (icaruscode/CRT/CRTProducts) and trigger-related ones (icaruscode/PMT/Trigger/Data). sbndcode only has CRT data products.

I suppose that the first step is to move only the first ones. @tgrbrooks and @chilge should confirm they are equivalent...

@PetrilloAtWork
Copy link
Member

Issue #10 created to track the creation of sbnobj repository.

@wesketchum
Copy link
Contributor

OK, #2 complete I think, allowing this to proceed.

@tgrbrooks
Copy link
Member

We need to identify which are the data products to be shared.
Currently icaruscode has CRT data products (icaruscode/CRT/CRTProducts) and trigger-related ones (icaruscode/PMT/Trigger/Data). sbndcode only has CRT data products.

I suppose that the first step is to move only the first ones. @tgrbrooks and @chilge should confirm they are equivalent...

I think our CRTHit and CRTTrack data products are the same but the CRTData products have diverged significantly between sbndcode and icaruscode

@wesketchum
Copy link
Contributor

OK, I'm starting to work on some of this migrating of data products now ...

@wesketchum
Copy link
Contributor

Initial branch at SBNSoftware/sbnobj#2

Have added in ICARUS PMT Trigger data objects, and CRT data objects across the board. For the CRT ones, I've made 'common' ones for CRTHit, CRTTrack, and CRTTzero, though I've also copied the existing versions in each namespace because I worried about backwards compatibility (those are in the _Legacy.hh file). We should consider if we need that/when we can drop it.

I've just allowed experiement-specific CRTData objects (with only namespaces differing to distinguish the names). We should also consider if we can merge those or what.

@PetrilloAtWork
Copy link
Member

This has been moved to the testing phase (#13).

@wesketchum
Copy link
Contributor

Initial implementation done. Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants