Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create/setup sbnobj repository #2

Closed
wesketchum opened this issue May 27, 2020 · 8 comments
Closed

Create/setup sbnobj repository #2

wesketchum opened this issue May 27, 2020 · 8 comments
Assignees
Labels
enhancement New feature or request

Comments

@wesketchum
Copy link
Contributor

Need an sbn object repository for sbn-specific objects to be added. sbncode should depend on it.

@wesketchum wesketchum added the enhancement New feature or request label May 27, 2020
@cjbacchus
Copy link
Contributor

Does this just entail creating the repository within github/SBNSoftware and then moving relevant pieces over?

Oh, and getting it added to the build procedure (who do we ask about this?). Where will it be installed? Presumably the new SBN CVMFS area?

I see this pattern of splitting objects out into a seperate products in various places. Is there somewhere I can read about the rationale for it?

@cjbacchus
Copy link
Contributor

cjbacchus commented Jun 15, 2020

The ticket is RITM0975699 sorry, commented on the wrong issue

@wesketchum
Copy link
Contributor Author

Thanks Chris! There's an associated link in sbncode#3 for the repo area. I'll add a comment on status there.

On your above comments, think we talked over slack, but can continue convo here if we need. I think at minimum an sbnobj repo would be good, but maybe we try to resist pulling too much out beyond that.

@wesketchum
Copy link
Contributor Author

#10 from @PetrilloAtWork is a duplicate of this issue. I'm closing that one and keeping this one. Gianluca had the following comment at that issue:

A repository sbnobj is needed hosting data products.
This issue is for the creation of the empty GIT/cetbuildtools based repository.

I think the dependencies should be either on lardataobj or with the same as nusimdata.

@cjbacchus
Copy link
Contributor

cjbacchus commented Jun 17, 2020

sorry, I commented on the wrong issue earlier.

#3 is about the CVMFS space for general externals, but we also need to create it in github and set it up as part of the build.

@wesketchum
Copy link
Contributor Author

I think I can do the github creation and try to give it a skeleton to work from ... let met give that a go right now.

@wesketchum wesketchum self-assigned this Jun 17, 2020
@wesketchum
Copy link
Contributor Author

OK, initial repo with lardataobj dependency is in SBNSoftware/sbnobj#1.

@wesketchum
Copy link
Contributor Author

Done, and part of the new releases. Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants