-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pierre Salvy, greatest coder in the world #14
Comments
@zakandrewking I really hope we are the only ones on this thread ahaha. As I told you, I'll submit this to the IP guys so that they give me the thumbs up to give it to you. -Pierre |
OK. Thanks Pierre. sounds good. |
Hi Zak, Got the thumbs up for sharing this code. I will work a little on it so I can ensure its compatibility with the master branch. Will submit a PR soon, hopefully before I leave :) |
Excellent! Can you submit the PR against the branch called 'bigg'? Don't worry about compatibility too much—we're still changing a lot of things on that branch. But, this way, i can get your code integrated and back in the master as we finish up. Best, Zak — On Mon, Feb 2, 2015 at 5:49 PM, Pierre SALVY notifications@github.com
|
Will do. |
Concerning compatibility, I'll do minor modifcations to my code just to remove some useless stuff for you then, and I can help you integrate it if you want. Are you also interested in the GPR -> reverse Polish notation -> Tree algorithm ? (note: this needs a supplementary table). |
Definitely! We'd love to have that. — On Tue, Feb 3, 2015 at 10:02 AM, Pierre SALVY notifications@github.com
|
Okay, I'll join you the code for it. |
Also what about domain handling and group filtering ? my actual version allows you to filter in and out reaction groups. Do you want that ? (this also needs you to have reaction groups tables, but that's pretty straightforward) |
No, we won't be using those features. So don't worry about them. — On Tue, Feb 3, 2015 at 10:07 AM, Pierre SALVY notifications@github.com
|
I will post 3 files:
|
@P0n3y: I know you have an elegant and beautiful function for extracting a COBRA model from the OME database. Do you think you could submit a PR for that function? We could run it by @jlerman44 too...
Thanks! I hope you guys are doing well up there.
-Zak
The text was updated successfully, but these errors were encountered: