Pierre Salvy, greatest coder in the world

[zakandrewking]

@P0n3y: I know you have an elegant and beautiful function for extracting a COBRA model from the OME database. Do you think you could submit a PR for that function? We could run it by @jlerman44 too...

Thanks! I hope you guys are doing well up there.

-Zak

[psalvy]

@zakandrewking I really hope we are the only ones on this thread ahaha. As I told you, I'll submit this to the IP guys so that they give me the thumbs up to give it to you.
I hope you guys are doing well down there :)

-Pierre

[zakandrewking]

OK. Thanks Pierre. sounds good.

[psalvy]

Hi Zak,

Got the thumbs up for sharing this code. I will work a little on it so I can ensure its compatibility with the master branch. Will submit a PR soon, hopefully before I leave :)

[zakandrewking]

Excellent! Can you submit the PR against the branch called 'bigg'? Don't worry about compatibility too much—we're still changing a lot of things on that branch. But, this way, i can get your code integrated and back in the master as we finish up. 

Best,

Zak

—
Sent from Mailbox

On Mon, Feb 2, 2015 at 5:49 PM, Pierre SALVY notifications@github.com
wrote:

Hi Zak,

Got the thumbs up for sharing this code. I will work a little on it so I can ensure its compatibility with the master branch. Will submit a PR soon, hopefully before I leave :)

Reply to this email directly or view it on GitHub:
#14 (comment)

[psalvy]

Will do.

[psalvy]

Concerning compatibility, I'll do minor modifcations to my code just to remove some useless stuff for you then, and I can help you integrate it if you want.

Are you also interested in the GPR -> reverse Polish notation -> Tree algorithm ? (note: this needs a supplementary table).

[zakandrewking]

Definitely! We'd love to have that. 

—
Sent from Mailbox

On Tue, Feb 3, 2015 at 10:02 AM, Pierre SALVY notifications@github.com
wrote:

Concerning compatibility, I'll do minor modifcations to my code just to remove some useless stuff for you then, and I can help you integrate it if you want.

Are you also interested in the GPR -> reverse Polish notation -> Tree algorithm ? (note: this needs a supplementary table).

Reply to this email directly or view it on GitHub:
#14 (comment)

[psalvy]

Okay, I'll join you the code for it.

[psalvy]

Also what about domain handling and group filtering ? my actual version allows you to filter in and out reaction groups. Do you want that ? (this also needs you to have reaction groups tables, but that's pretty straightforward)

[zakandrewking]

No, we won't be using those features. So don't worry about them. 

—
Sent from Mailbox

On Tue, Feb 3, 2015 at 10:07 AM, Pierre SALVY notifications@github.com
wrote:

Also what about domain handling and group filtering ? my actual version allows you to filter in and out reaction groups. Do you want that ? (this also needs you to have reaction groups tables, but that's pretty straightforward)

Reply to this email directly or view it on GitHub:
#14 (comment)

[psalvy]

I will post 3 files:

• The pull_model script that handles the heavy lifting
• The gpr_rpn_tree file that does the eval/compilation of GPRs
• browsing_tools which is a bunch of functions for interacting with the database
  Since you are rewriting a lot of stuff, as agreed, you might have to go through the main script (pull_model) to glue everything together.
  I will submit the PR as @Amyris.