Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support separator in select prompt #1231

Merged
merged 2 commits into from
May 13, 2023

Conversation

zonemeen
Copy link
Collaborator

Initial solution on #1230

If this solution works, I will add it to the rest of the prompts.

@codecov
Copy link

codecov bot commented May 12, 2023

Codecov Report

Patch coverage: 73.91% and project coverage change: -0.04 ⚠️

Comparison is base (f3bfe3b) 78.76% compared to head (9425cb0) 78.73%.

❗ Current head 9425cb0 differs from pull request most recent head f573276. Consider uploading reports for the commit f573276 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1231      +/-   ##
==========================================
- Coverage   78.76%   78.73%   -0.04%     
==========================================
  Files          34       35       +1     
  Lines        3575     3598      +23     
  Branches      576      578       +2     
==========================================
+ Hits         2816     2833      +17     
- Misses        187      192       +5     
- Partials      572      573       +1     
Impacted Files Coverage Δ
packages/core/src/lib/Separator.mts 64.70% <64.70%> (ø)
packages/core/src/index.mts 79.18% <100.00%> (+0.65%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@SBoudrias
Copy link
Owner

I went ahead addressing my PR comments. Hoping to get this in today!

Thanks for sending the PR and doing most of the work, it definitively helped!

@SBoudrias SBoudrias changed the title feat: support separator in select type feat: support separator in select prompt May 13, 2023
@SBoudrias SBoudrias merged commit b5ee6fd into SBoudrias:master May 13, 2023
@zonemeen
Copy link
Collaborator Author

Nice work! I'm also happy to be involved in boosting Inquirer.js.

@zonemeen zonemeen deleted the feat/separator branch May 14, 2023 00:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants