Fix @inquirer/confirm formatted output value #918
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
@inquirer/confirm
value is formatted twice, on keypress and once done for display:Inquirer.js/packages/confirm/index.js
Lines 13 to 14 in 32ee96f
Inquirer.js/packages/confirm/index.js
Lines 24 to 25 in 32ee96f
This means the final formatted value is always
yes
, even if the entered value isno
:(callback value is correct, as it is not called with the formatted value.)
This PR removes the second formatting, thus fixing the issue: