Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The fatest way to disable fullscreen warning text #2478

Closed
AndreLuisSilva opened this issue Mar 10, 2023 · 4 comments
Closed

The fatest way to disable fullscreen warning text #2478

AndreLuisSilva opened this issue Mar 10, 2023 · 4 comments
Labels
community Community Reported Issues feature request
Milestone

Comments

@AndreLuisSilva
Copy link

Hello, I'm migrating a project from ScadaBR 1.2 to the ScadaLTS v2.6.18 version, and I realized some things that had already been implemented in ScadaBR that can be added in the future in ScadaLTS, one of them is the option to disable the "Ctrl + Shift + F" that appears every time the page is updated, in ScadaBR there is a variable inside the views.jsp file where it is possible to enable and disable, if there is a check box somewhere in the future that enables and disables it, it would be more intuitive for the end user, and also the possibility of enabling the "padding 0" of the graphic view to remove the upper border when it is left in full screen with the F11 key, in ScadaBR I would insert a style="padding: 0px;" in the "mainContent" div, now in ScadaLTS I needed to add this padding to the "sltsContent" div and even then a small border still remained when in full screen, and with that I realized that it was necessary to add one more style=padding: 0px inside a table in the views.jsp file, I also added a style="overflow: hidden;" inside the html tag in the page.tag file so that the scroll bar disappears to leave ScadaLTS in fullscreen, this is the only way I managed to make the ScadaLTS screen the same as ScadaBR and manage to migrate my platform project, I will attach some images to show the before and after the changes I made so you can understand how it turned out.

Without the changes
Captura de Tela (43)

Message that appears every time the page is refreshed
Captura de Tela (42)

After the changes
Captura de Tela (40)

@Limraj Limraj added the community Community Reported Issues label Mar 10, 2023
@Limraj
Copy link
Collaborator

Limraj commented Mar 10, 2023

Hi @AndreLuisSilva,
You can suggest specific changes in the pull request.

Regards,
Kamil Jarmusik

@fabiodurao
Copy link

Hello Limraj, I asked him to report the modification he made, because in ScadaBR we already had a padding of 5px that we didn't like and we always took it off in projects, but before it was just changing the page.tag file and resetting the padding, now there are a few more changes needed.

1 - The suggestion would be to remove the pading or the white border around the representations. We do all this to be able to create an image, for example, with 1920x1050 to be used in full screen (from scada-lts and the browser) in a 1920x1080 resolution (discounting 30px to maintain copyright) and to be able to fully frame the graphic representation on the screen without having to use scroll bar;

2 - Taking advantage of this, the native scrollbar is a little hidden and I often need to resize the page to be able to see something if it is not in fullscreen, it could just be the css of the scrollbar. In parallel, the colleague had to remove the scroll bar in the css even with the screen in fullscreen to be able to frame the screen 100%;

3 - The text "Press ctrl+shift+f to exit fullscreen" is great for those who are new to the system, but when we put a project into production to be used in fullscreen, this text gets in the way a lot, because it takes up more space and because it fades out 10 seconds later. As we usually don't want the user to leave fullscreen and navigate only through the links we create, we usually remove this text by changing views.jsp . I believe that a simpler approach would be to add a checkbox on the scada-lts settings screen with the text "don't display the instruction to exit fullscreen".

@Limraj
Copy link
Collaborator

Limraj commented Apr 17, 2023

Hi @AndreLuisSilva and @fabiodurao ,
I think I met all the requirements:

  1. There is a checkbox to select if you want to see a message with a shortcut to disable full screen mode - it is unchecked by default;
  2. Refreshing the page does not show this shortcut again;
  3. For fullscreen mode, I set the padding to 0px, now the fullscreen view starts and ends before the copyright footer, there are no empty spaces.

fixes will be included in the next version 2.7.5.3

@fabiodurao I would appreciate if you could test it:
#2514

Limraj added a commit that referenced this issue Apr 20, 2023
…eters: forceFullScreen and hideShortcutDisableFullScreen to System Settings; added parameters: enableFullScreen and hideShortcutDisableFullScreen to User; center/middle text in button (layout.css)
Limraj added a commit that referenced this issue Apr 28, 2023
…ui: added fields: enableFullScreen, hideShortcutDisableFullScreen to MiscSettingsComponent; added fields: enableFullScreen, hideShortcutDisableFullScreen in UserDetails; removed deprecated: EventDetectorsCache, EventDetectorsCacheDAO, UpdateEventDetectors, JsonDataPoint, JsonUser, JsonUserInfo, JsonUserPassword
@Limraj
Copy link
Collaborator

Limraj commented May 2, 2023

Hi @fabiodurao and @AndreLuisSilva,
The last form of this function:

  1. Ability to set the following options in the user:
    a) Enable full screen mode - if it is set to true, and there is at least one view, then if the user enters Graphical Views, it forces full screen mode, each user can disable it with a shortcut;
    b) Hide shortcut to disable full screen - disables the shortcut when switching to full screen;
    Old ui:
    login as admin:
    Screenshot 2023-05-02 at 12 04 05
    login as non-admin:
    Screenshot 2023-05-02 at 12 04 33
    New ui:
    login as admin:
    Screenshot 2023-05-02 at 12 06 07
    login as non-admin:
    Screenshot 2023-05-02 at 12 05 32

  2. Possibility to force setting in System Settings, only admin can do it:
    a) Force full screen mode - setting this option forces all users to full screen mode, additionally, a normal user cannot return to normal mode, an admin can and the "Enable full screen mode" checkbox in the user is greyed out and the user cannot change his state , after hovering over the checkbox, information appears about the reason for this state;
    b) Hide shortcut to disable full screen - this forces all users to have no shortcut visibility, the "Hide shortcut to disable full" option in the user is greyed out, after hovering over the checkbox there is information about what this state is due to;
    Old ui (System Settings):
    Screenshot 2023-05-02 at 12 08 44
    New ui (System Settings):
    Screenshot 2023-05-02 at 12 07 25

Regards,
Kamil Jarmusik

Limraj added a commit that referenced this issue May 8, 2023
…to_disable_fullscreen_warning_text

#2478 The fatest way to disable fullscreen warning text
@Limraj Limraj closed this as completed May 16, 2023
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community Community Reported Issues feature request
Projects
None yet
Development

No branches or pull requests

3 participants